Skip to content

fix: replace pgbouncer readinessProbe with startupProbe #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thesuperzapper merged 1 commit into from
Mar 31, 2022
Merged

fix: replace pgbouncer readinessProbe with startupProbe #547

thesuperzapper merged 1 commit into from
Mar 31, 2022

Conversation

@thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Mar 22, 2022 •
edited
Loading

What issues does your PR fix?

What does your PR do?

  • Replaces the PgBouncer "readinessProbe" with a "startupProbe" to prevent intermittent socket failures causing the "livenessProbe" to fail:
  • Added the following values:
    • pgbouncer.startupProbe.enabled (default: true)
    • pgbouncer.startupProbe.initialDelaySeconds (default: 5)
    • pgbouncer.startupProbe.periodSeconds (default: 10)
    • pgbouncer.startupProbe.timeoutSeconds (default: 15)
    • pgbouncer.startupProbe.failureThreshold (default: 30)

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Mar 22, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Mar 22, 2022
@thesuperzapper thesuperzapper force-pushed the pgbouncer-probe-fixes branch from 9957575 to 4c24c35 Compare March 31, 2022 23:09
@thesuperzapper thesuperzapper merged commit dd6d57f into airflow-helm:main Mar 31, 2022
@thesuperzapper thesuperzapper deleted the pgbouncer-probe-fixes branch March 31, 2022 23:40
@thesuperzapper thesuperzapper mentioned this pull request Apr 14, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Issue Triage and PR Tracking
Archived in project

Milestone

airflow-8.6.0

Development

Successfully merging this pull request may close these issues.

replace PGBouncer's readinessProbe with startupProbe pgbouncer readinessProbe timeouts cause livenessProbe failures

1 participant

@thesuperzapper