feat: add airflow.kubernetesPodTemplate.extraContainers
#456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashartwig
changed the title
thesuperzapper
requested changes
Nov 11, 2021
Member
thesuperzapper
left a comment
thesuperzapper
left a comment
There was a problem hiding this comment.
@jonashartwig thanks for the PR!
I have left a few small comments so we can get this merged!
thesuperzapper
changed the title
Signed-off-by: cvv556 <[email protected]>
Contributor
Author
|
Thank you for taking the time and giving feedback. I adjusted my PR to accompany your requests. |
thesuperzapper
changed the title
airflow.kubernetesPodTemplate.extraContainers
Member
|
@jonashartwig thanks for your work, I have added this to the |
3 tasks
Contributor
Author
|
Happy to hear :) |
thesuperzapper
previously approved these changes
Feb 17, 2022
Member
thesuperzapper
left a comment
thesuperzapper
left a comment
There was a problem hiding this comment.
This is ready for the 8.6.0 release, and will be merged before we cut it.
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
What does your PR do?
airflow.kubernetesPodTemplate.extraContainersvalue to specify extra containers in the KubernetesExecutor pod_template.Checklist
For all Pull Requests
For releasing ONLY