Skip to content

feat: add airflow.kubernetesPodTemplate.extraInitContainers #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thesuperzapper merged 1 commit into from
Apr 1, 2022
Merged

feat: add airflow.kubernetesPodTemplate.extraInitContainers #446

thesuperzapper merged 1 commit into from
Apr 1, 2022

Conversation

@jmcgrath207
Copy link
Contributor

@jmcgrath207 jmcgrath207 commented Oct 22, 2021 •
edited by thesuperzapper
Loading

What issues does your PR fix?

N/A

What does your PR do?

  • Adds the airflow.kubernetesPodTemplate.extraInitContainers value to specify extra init-containers in the KubernetesExecutor pod_template.

Checklist

For all Pull Requests

For releasing ONLY

@jmcgrath207 jmcgrath207 changed the title adding kubernetesPodTemplate extra Init container feat: kubernetesPodTemplate extra Init container Oct 26, 2021
@jmcgrath207 jmcgrath207 force-pushed the main branch 2 times, most recently from 68a2c81 to 2ef8cf8 Compare October 26, 2021 16:56
@jmcgrath207
Copy link
Contributor Author

jmcgrath207 commented Nov 5, 2021

Hey @thesuperzapper @gsemet , is there anything else I need to do to get this merged?

thesuperzapper
thesuperzapper requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcgrath207 thanks for the PR, I have left a small fix that is needed before we can merge.

thesuperzapper
thesuperzapper reviewed Nov 11, 2021
View reviewed changes
@thesuperzapper thesuperzapper changed the title feat: kubernetesPodTemplate extra Init container feat: add kubernetesPodTemplate.extraInitContainers Nov 11, 2021
@thesuperzapper thesuperzapper changed the title feat: add kubernetesPodTemplate.extraInitContainers feat: add extra init-containers to kubernetesPodTemplate Nov 11, 2021
jmcgrath207
jmcgrath207 commented Nov 19, 2021
View reviewed changes
Copy link
Contributor Author

@jmcgrath207 jmcgrath207 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes complete. Waiting for approval

@thesuperzapper
Copy link
Member

thesuperzapper commented Dec 14, 2021

@jmcgrath207 thanks for your work!

I will put this in the 8.6.0 milestone (as it adds a new value).

@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Dec 14, 2021
@thesuperzapper thesuperzapper changed the title feat: add extra init-containers to kubernetesPodTemplate feat: add airflow.kubernetesPodTemplate.extraInitContainers Dec 14, 2021
thesuperzapper
thesuperzapper requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcgrath207 I just realized you were not correctly referencing the value you created.

The value is airflow.kubernetesPodTemplate.extraInitContainers, not kubernetesPodTemplate.extraInitContainers.

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Feb 13, 2022
@thesuperzapper
Copy link
Member

thesuperzapper commented Feb 17, 2022

@jmcgrath207 do you still have time to apply the changes needed to address comments in #446 (review)?

@stale stale bot closed this Feb 24, 2022
@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Feb 25, 2022
thesuperzapper
thesuperzapper approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcgrath207 I have gone ahead and fixed your PR, so it can be merged for 8.6.0.

@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Mar 22, 2022
@airflow-helm airflow-helm deleted a comment from stale bot Mar 22, 2022
@thesuperzapper thesuperzapper merged commit 5b44e9d into airflow-helm:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thesuperzapper thesuperzapper thesuperzapper approved these changes

@gsemet gsemet Awaiting requested review from gsemet

Assignees

No one assigned

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Issue Triage and PR Tracking
Archived in project

Milestone

airflow-8.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jmcgrath207 @thesuperzapper