feat: add airflow.clusterDomain value
#441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexey.kasatikov <[email protected]>
thesuperzapper
requested changes
Oct 4, 2021
Member
thesuperzapper
left a comment
thesuperzapper
left a comment
There was a problem hiding this comment.
@alexkasatikov thanks for the PR, just a small nitpick on the docstring, otherwise looks good!
Signed-off-by: alexey.kasatikov <[email protected]>
Member
|
@alexkasatikov thanks for this PR, it looks good to merge! I will wait until we plan to cut the next release to merge (so people don't think this feature is already in the chart when they look at the NOTE: since this adds the |
thesuperzapper
changed the title
airflow.clusterDomain value
Member
|
Bumping for the bot, we still plan to merge this as part of the |
thesuperzapper
approved these changes
Feb 17, 2022
Member
thesuperzapper
left a comment
thesuperzapper
left a comment
There was a problem hiding this comment.
This PR is ready for 8.6.0, and will be merged as that release is cut.
thesuperzapper
added
the
status/ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
cluster.localdomains break internal DBs #476What does your PR do?
airflow.clusterDomainvalue (default:cluster.local) to allow setting the KubeletclusterDomainto non-standard values.Checklist
For all Pull Requests
For releasing ONLY