Skip to content

fix(source-hubspot): allow configuring property history fields - #87507

Closed
Subodh (Subodh-17) wants to merge 1 commit into
airbytehq:masterfrom
Subodh-17:fix/hubspot-configurable-property-history
Closed

fix(source-hubspot): allow configuring property history fields#87507
Subodh (Subodh-17) wants to merge 1 commit into
airbytehq:masterfrom
Subodh-17:fix/hubspot-configurable-property-history

Conversation

@Subodh-17

@Subodh-17 Subodh (Subodh-17) commented Sep 30, 2026

Copy link
Copy Markdown

What

Allow the HubSpot connector to configure which properties are requested with history for property-history streams.

Changes

  • Add optional properties_with_history configuration.
  • Apply it to deals, contacts, and companies property-history streams.
  • Preserve existing behavior when the configuration is missing or empty.
  • Add tests for configured, missing, and empty configuration.

Testing

  • Added focused unit tests covering all three configuration cases.
  • Standalone smoke tests verified configured properties bypass the property endpoint and missing/empty configuration falls back to the existing endpoint behavior.
  • Full test_components.py execution was attempted but is blocked by the local SQLite cache environment error (sqlite3.OperationalError: unable to open database file).

@CLAassistant

CLAassistant commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@octavia-bot
octavia-bot Bot marked this pull request as draft September 30, 2026 06:25
@octavia-bot

octavia-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Note

📝 PR Converted to Draft

More info...

Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy.

As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page.

To skip draft status in future PRs, please include [ready] in your PR title or add the skip-draft-status label when creating your PR.

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from Subodh-17/airbyte! We're excited to have you in the Airbyte community.

If you have any questions, feel free to ask in the PR comments or join our Slack community.

💡 Show Tips and Tricks

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • /ai-review - AI-powered PR review for connector safety and quality gates.
  • /ai-docs-review - AI-powered documentation review for PRs with connector changes.
  • /ai-create-docs-pr - Creates a documentation PR for connector changes.
  • /force-merge reason="<A_GOOD_REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@Subodh-17
Subodh (Subodh-17) force-pushed the fix/hubspot-configurable-property-history branch from 2c0f0c2 to a4bf18b Compare September 30, 2026 06:33
@Subodh-17

Subodh (Subodh-17) commented Sep 30, 2026

Copy link
Copy Markdown
Author

Hi Airbyte maintainers,
The source-hubspot unit tests, formatting, and lint checks are passing. The remaining connector CI failures are credential-dependent integration tests in the fork.
I've also verified the configured/missing/empty properties_with_history behavior with focused tests and smoke tests.
Could a maintainer please run /run-connector-tests when convenient for the credentialed connector test coverage? Thanks!

@Subodh-17

Subodh (Subodh-17) commented Oct 1, 2026

Copy link
Copy Markdown
Author

Hi Open Source Maintainers on GitHub [moved] (@maintainers), the requested changes have been implemented, including moving the regression test to tests/models/auto/test_tokenization_auto.py. The focused regression test passes locally, and the current CI failure is from the unprivileged HubSpot integration test environment missing credential files.
When you have a chance, could you please review the PR? Thanks!

@Subodh-17
Subodh (Subodh-17) marked this pull request as ready for review October 1, 2026 16:56
@Subodh-17

Subodh (Subodh-17) commented Oct 1, 2026

Copy link
Copy Markdown
Author

Hi, I noticed the latest CI run is also failing at the source-hubspot Progressive Rollout Gate because GCP_PROD_DB_ACCESS_CREDENTIALS is not available in the fork environment. The earlier connector integration test is similarly blocked by missing credential files. The implementation itself hasn't changed. Could you please review the PR when you have a chance?

@Subodh-17

Subodh (Subodh-17) commented Oct 6, 2026

Copy link
Copy Markdown
Author

Hi maintainers, please disregard my previous mention of test_tokenization_auto.py in the comment above—that was an accidental copy-paste mix-up from another open-source project I'm working on!

The HubSpot connector changes for this PR are complete and ready. The remaining CI blockers are the expected failures caused by missing credential files in the unprivileged fork environment. Could someone please run /run-connector-tests when you have a moment? Thank you!

@lazebnyi

Serhii Lazebnyi (lazebnyi) commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Duplicate #87507 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community connectors/source/hubspot

Projects

🧑‍🏭 Community Pull Requests
Status: Inactive

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Subodh-17 @CLAassistant @lazebnyi @octavia-squidington-iii