chore: first batch of migration to CDK v7#65966
chore: first batch of migration to CDK v7#65966Brian Lai (brianjlai) merged 3 commits intomasterfrom
Conversation
Octavia Squidington III (octavia-squidington-iii)
added
connectors/source/babelforce
connectors/source/rd-station-marketing
connectors/source/appfigures
connectors/source/buildkite
connectors/source/kissmetrics
connectors/source/incident-io
connectors/source/marketstack
connectors/source/firehydrant
connectors/source/pretix
connectors/source/perigon
labels
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
| ql: 100 | ||
| supportLevel: community | ||
| connectorBuildOptions: | ||
| baseImage: docker.io/airbyte/source-declarative-manifest:6.48.16@sha256:651a0bbdc634378737fb833fdf43666f9d9b5b633c68a35cc03ab6e56cb4d6e7 |
There was a problem hiding this comment.
I am a bit worried that the CDK version is that old
There was a problem hiding this comment.
that is interesting. it seems like it hasn't been able to get CI to pass since May. The most recent run says it failed a format check, but it looks like the CI process failed.
#61452
Kind of suspicious, but also a potentially very unused connector. yolo!
There was a problem hiding this comment.
Yolo indeed
There was a problem hiding this comment.
well now I'm getting pinged about it 😄
There was a problem hiding this comment.
seems like it was just a coincidence that this connector failed to publish. Rerunning the workflow fixed it
There was a problem hiding this comment.
oh okay so it was a ping about the publish? not like the connector having repeated errors in prod? thanks for the heads up though! if the latter, I'd have been more concerned that we're getting paged for connectors that are uncertified
There was a problem hiding this comment.
Correct, just about the publish
| type: GSM | ||
| alias: airbyte-connector-testing-secret-store | ||
| connectorBuildOptions: | ||
| baseImage: docker.io/airbyte/source-declarative-manifest:6.48.10@sha256:09947fb38d07e515f9901a12f22cc44f1512f6148703341de80403c0e0c1b8c3 |
There was a problem hiding this comment.
I am a bit worried that the CDK version is that old
|
Maxime Carbonneau-Leclerc (maxi297)
requested a review
from Brian Lai (brianjlai)
|
|
|
|
|
|
|
|
|
|
Deploy preview for airbyte-docs ready! Built with commit 7371c32. |
| ql: 100 | ||
| supportLevel: community | ||
| connectorBuildOptions: | ||
| baseImage: docker.io/airbyte/source-declarative-manifest:6.48.16@sha256:651a0bbdc634378737fb833fdf43666f9d9b5b633c68a35cc03ab6e56cb4d6e7 |
There was a problem hiding this comment.
that is interesting. it seems like it hasn't been able to get CI to pass since May. The most recent run says it failed a format check, but it looks like the CI process failed.
#61452
Kind of suspicious, but also a potentially very unused connector. yolo!
|
reading through the 3 failing sources:
TLDR: Force merging since all errors are somewhat expected since many of our long tail connectors don't have proper test creds and there is evidence from the others that the bump to v7 can still execute and doesn't trip over a breaking change |
4 participants
What
Starting the migration to CDK v7 with a batch of 10 connectors.
How
Running the CDK migration script with an added condition of
not self.has_pyproject.Note that the script didn't get the changelog updates properly so I updated some manually which reformatted the whole changelog table
Review guide
User Impact
Can this PR be safely reverted and rolled back?