Skip to content

Comments

Source Babelforce: Migrate to manifest-only#43439

Merged
Natik Gadzhi (natikgadzhi) merged 2 commits intomasterfrom
christo/babelforce-manifest-only
Aug 9, 2024
Merged

Source Babelforce: Migrate to manifest-only#43439
Natik Gadzhi (natikgadzhi) merged 2 commits intomasterfrom
christo/babelforce-manifest-only

Conversation

@ChristoGrab
Copy link
Contributor

@ChristoGrab Christo Grabowski (ChristoGrab) commented Aug 9, 2024 •
edited
Loading

What

Migrates source-babelforce to manifest-only format

How

Ran the airbyte-ci commands [migrate-to-manifest-only, bump-version, format fix]

Review Guide

  1. manifest.yaml: should be at the root level of the folder, list version 4.3.0 and contain an inline spec
  2. metadata.py: should list the correct manifest-only language tag and point to a recent version of source-declarative-manifest
  3. acceptance-test-config.yml: should correctly point to manifest.yaml for the spec test
  4. readme.md: Should be updated with correct references to the connector (this has historically been a sticking point with our READMEs)
  5. Pretty much everything else should be nuked

User Impact

None

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel
Copy link

vercel bot commented Aug 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 5:53pm

@ChristoGrab Christo Grabowski (ChristoGrab) marked this pull request as ready for review August 9, 2024 17:46
@natikgadzhi Natik Gadzhi (natikgadzhi) merged commit 632ef02 into master Aug 9, 2024
@natikgadzhi Natik Gadzhi (natikgadzhi) deleted the christo/babelforce-manifest-only branch August 9, 2024 20:35
Louis Auneau (LouisAuneau) pushed a commit to LouisAuneau/airbyte that referenced this pull request Aug 13, 2024
@ChristoGrab @LouisAuneau
Source Babelforce: Migrate to manifest-only (airbytehq#43439)
b14ebe7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@natikgadzhi Natik Gadzhi (natikgadzhi) natikgadzhi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/babelforce

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristoGrab @natikgadzhi @octavia-squidington-iii