✨Source Weatherstack - Migrate Python CDK to Low-code CDK#43298
Merged
Natik Gadzhi (natikgadzhi) merged 7 commits intomasterfrom Aug 8, 2024
Merged
✨Source Weatherstack - Migrate Python CDK to Low-code CDK#43298Natik Gadzhi (natikgadzhi) merged 7 commits intomasterfrom
Natik Gadzhi (natikgadzhi) merged 7 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Natik Gadzhi (natikgadzhi)
left a comment
Natik Gadzhi (natikgadzhi)
left a comment
There was a problem hiding this comment.
This is good, thank you Tope Folorunso (@topefolorunso)!
A few things I noted:
- https URLs everywhere. HTTP will not (and did not) pass the validation.
- Fix the formatting (
/format-fixwould do that) - Use standard
YamlDeclarativeSourcewrapper. Don't remove two streams for free accounts. In fact, I would remove theis_paid_accountconfig input altogether, and just set an error handler to ignore HTTP 403 on those two streams.
Christo Grabowski (@ChristoGrab) and I are happy to help with the error handler if that gets tricky.
airbyte-integrations/connectors/source-weatherstack/source_weatherstack/manifest.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-weatherstack/source_weatherstack/source.py
Outdated
Show resolved
Hide resolved
Contributor
|
Minimal tests are passing! I would call this a 1.0.0, drop |
Collaborator
Author
|
all done Natik Gadzhi (@natikgadzhi). please see if the breaking change was done properly |
Tope Folorunso (topefolorunso)
requested a review
from Natik Gadzhi (natikgadzhi)
Natik Gadzhi (natikgadzhi)
approved these changes
Aug 8, 2024
Contributor
Natik Gadzhi (natikgadzhi)
left a comment
Natik Gadzhi (natikgadzhi)
left a comment
There was a problem hiding this comment.
Code looks good.
Natik Gadzhi (natikgadzhi)
deleted the
tope/migrate-weatherstack-lowcode
branch
Louis Auneau (LouisAuneau)
pushed a commit
to LouisAuneau/airbyte
that referenced
this pull request
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate Weatherstack Python CDK to Low-code CDK fixes https://github.com/airbytehq/airbyte-internal-issues/issues/8958
How
Developed using UI Builder and the Low-code CDK
Recommended reading order
manifest.yaml🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.