Bulk update deprecated authenticators#40549
Merged
Christo Grabowski (ChristoGrab) merged 8 commits intomasterfrom Jun 26, 2024
Merged
Bulk update deprecated authenticators#40549Christo Grabowski (ChristoGrab) merged 8 commits intomasterfrom
Christo Grabowski (ChristoGrab) merged 8 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Christo Grabowski (ChristoGrab)
requested review from
Augustin (alafanechere) and
Natik Gadzhi (natikgadzhi)
Augustin (alafanechere)
approved these changes
Jun 26, 2024
Contributor
Augustin (alafanechere)
left a comment
Augustin (alafanechere)
left a comment
There was a problem hiding this comment.
Lucky you, all 🟢 CI! I'd otherwise advise to create per connector PR with airbyte-ci connectors pull-request.
Christo Grabowski (ChristoGrab)
deleted the
christo/bulk-authenticator-update
branch
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates a number of our source connectors still using the deprecated
authpackage from the Python CDK. In some cases the connector was already migrated but still using the deprecated package in tests. These are the connectors that pass acceptance tests out the gate:The full list of remaining sources to migrate is listed here:
How
authpackage withrequests_native_authauthenticatorattribute with_session.authNoAuth()(mostly in tests) withauthenticator=NoneCan this PR be safely reverted and rolled back?