Skip to content

Comments

✨Source Babelforce: Make Connector Compatible with Builder#38776

Merged
Augustin (alafanechere) merged 5 commits intomasterfrom
source-babelforce-make-builder-compatible
Jun 13, 2024
Merged

✨Source Babelforce: Make Connector Compatible with Builder#38776
Augustin (alafanechere) merged 5 commits intomasterfrom
source-babelforce-make-builder-compatible

Conversation

@pabloescoder
Copy link
Collaborator

What

Makes the connector compatible with the Builder UI

How

  • Import schema to Inline Schema in manifest
  • Remove $parameters
  • Bump minor version
  • Make it compatible with the Builder

User Impact

Non impacting, done for maintainability

Can this PR be safely reverted and rolled back?

  • YES 💚

@vercel
Copy link

vercel bot commented May 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 5:12pm

@natikgadzhi
Copy link
Contributor

Put auto-merge on it.

@pabloescoder
Copy link
Collaborator Author

Dhroov Makwana (pabloescoder) commented Jun 12, 2024

Put auto-merge on it.

There are a few issues that I need to fix, will make those changes and then put the auto-merge tag
Thanks for adding it!

@natikgadzhi
Copy link
Contributor

Before you fix things that CI marks as red, it's not going to get merged, so might as well slap the label first thing ;)

@alafanechere Augustin (alafanechere) merged commit f4cb64e into master Jun 13, 2024
@alafanechere Augustin (alafanechere) deleted the source-babelforce-make-builder-compatible branch June 13, 2024 00:14
@pabloescoder
Copy link
Collaborator Author

Before you fix things that CI marks as red, it's not going to get merged, so might as well slap the label first thing ;)

Ah I see! That's great, will add the label right away for any other make compatible with Builder PRs that I made/will make 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation auto-merge connectors/source/babelforce

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants