Skip to content

Comments

Migrate Babelforce Source Connector to Low Code#29314

Merged
Octavia The Approver (octavia-approvington) merged 5 commits intoairbytehq:masterfrom
topefolorunso:babelforce-low-code
Aug 24, 2023
Merged

Migrate Babelforce Source Connector to Low Code#29314
Octavia The Approver (octavia-approvington) merged 5 commits intoairbytehq:masterfrom
topefolorunso:babelforce-low-code

Conversation

@topefolorunso
Copy link
Collaborator

@topefolorunso Tope Folorunso (topefolorunso) commented Aug 9, 2023

What

Migrating Source Babelforce to Low-Code CDK resolves #29259

How

Created the connector using the connector buider UI, then imported the manifest.yaml to the low code cdk.

Recommended reading order

  1. manifest.yaml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@marcosmarxm Marcos Marx (marcosmarxm) added team/tse Technical Support Engineers Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 labels Aug 10, 2023
@marcosmarxm
Copy link
Contributor

Marcos Marx (marcosmarxm) commented Aug 15, 2023

Hello 👋 , right now Airbyte's integration tests are failing for this connector and I'm going to work during the week to fix them. Due a high number of contributions we have a backlog and your contribution will be review next week. We ask to you share the integration test from your side whatever possible and if you don't have credentials to run tests to get in touch with Chris "Sean" Dabatos (@RealChrisSean) as soon as possible. Also some common missing steps contributors does migrating to low code are (and you can double check to make sure you implemented this):

  • adding paginator
  • update the documentation changelog + metadata file and dockerfile version
  • if the connector has start_date parameter you must implement incremental syncs

marcosmarxm
Marcos Marx (marcosmarxm) suggested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@marcosmarxm Marcos Marx (marcosmarxm) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, after we're ready to merge

@topefolorunso
Copy link
Collaborator Author

Tope Folorunso (topefolorunso) commented Aug 23, 2023

I think the correct path should be calls/reporting/simple. The one using today is returning a csv format api.babelforce.com/#e0e4ec76-c14a-407c-bd77-17bc9ad29ab0

path fixed now Marcos Marx (@marcosmarxm)

@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Aug 24, 2023
@marcosmarxm
Copy link
Contributor

Marcos Marx (marcosmarxm) commented Aug 24, 2023

/approve-and-merge reason="no credentials, migration for one stream looks correct"

@octavia-approvington
Copy link
Contributor

Octavia The Approver (octavia-approvington) commented Aug 24, 2023

Enough! Let's do this
goooooo!

Harry Touloupas (harrytou) pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@topefolorunso @marcosmarxm @harrytou
Migrate Babelforce Source Connector to Low Code (airbytehq#29314)
d48751d 
Co-authored-by: marcosmarxm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@marcosmarxm Marcos Marx (marcosmarxm) marcosmarxm requested changes

@octavia-approvington Octavia The Approver (octavia-approvington) octavia-approvington approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/babelforce Hackathon External low-code/ui connector builder hackathons hackathon-2023-08 team/tse Technical Support Engineers

Projects

No open projects
Community Contributed PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Babelforce

4 participants

@topefolorunso @marcosmarxm @octavia-approvington @octavia-squidington-iii