Skip to content

Fix destination-exasol build and CatalogDefinition generation#23321

Merged
Evan Tahler (evantahler) merged 8 commits intomasterfrom
evan/fix-exasol
Feb 22, 2023
Merged

Fix destination-exasol build and CatalogDefinition generation#23321
Evan Tahler (evantahler) merged 8 commits intomasterfrom
evan/fix-exasol

Conversation

@evantahler
Copy link
Copy Markdown
Contributor

@evantahler Evan Tahler (evantahler) commented Feb 22, 2023 •
edited
Loading

Fixes the destination-exasol build (added via #21200). Lots of stuff changed when we ripped apart our monorepo 😅

Tested locally via

./gradlew :airbyte-integrations:connectors:destination-exasol:test :airbyte-integrations:connectors:destination-exasol:integrationTest

@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 22, 2023
@evantahler Evan Tahler (evantahler) mentioned this pull request Feb 22, 2023
Merged
18 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 22, 2023 •
edited
Loading

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)
Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (1)
Connector Version Changelog Publish
destination-exasol 0.1.1 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@evantahler Evan Tahler (evantahler) changed the title fix exasol build Fix destination-exasol build Feb 22, 2023
@evantahler Evan Tahler (evantahler) marked this pull request as ready for review February 22, 2023 00:43
@evantahler
Copy link
Copy Markdown
Contributor Author

Evan Tahler (evantahler) commented Feb 22, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/destination-exasol

🕑 connectors/destination-exasol https://github.com/airbytehq/airbyte/actions/runs/4238261941
✅ connectors/destination-exasol https://github.com/airbytehq/airbyte/actions/runs/4238261941
No Python unittests run

Build Passed

Test summary info:

All Passed

@evantahler
Copy link
Copy Markdown
Contributor Author

Evan Tahler (evantahler) commented Feb 22, 2023

Debugging:

SUB_BUILD=ALL_CONNECTORS ./gradlew :airbyte-config:specs:generateOssConnectorCatalog does add the new connector
SUB_BUILD=ALL_CONNECTORS ./gradlew :airbyte-config:init:test fails the test AND rebuilds the file, removing the new connector

Merged
@bnchrch Ben Church (bnchrch) requested a review from a team February 22, 2023 01:59
bnchrch
Ben Church (bnchrch) reviewed Feb 22, 2023
View reviewed changes
airbyte-config/specs/build.gradle
args new File(project(":airbyte-config:init").projectDir, '/src/main/resources/seed')
}

task downloadCombinedConnectorCatalog(type: JavaExec, dependsOn: compileJava) {
Copy link
Copy Markdown
Contributor

@bnchrch Ben Church (bnchrch) Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedro S. Lopez (@pedroslopez) Sanity check, we can delete all the download logic in connectors. Correct?

Copy link
Copy Markdown
Contributor

@pedroslopez Pedro S. Lopez (pedroslopez) Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct!

bnchrch
Ben Church (bnchrch) approved these changes Feb 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bnchrch Ben Church (bnchrch) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evan Tahler (@evantahler) Should be good to merge 👍

@bnchrch Ben Church (bnchrch) enabled auto-merge (squash) February 22, 2023 15:41
@bnchrch Ben Church (bnchrch) enabled auto-merge (squash) February 22, 2023 15:50
@evantahler
Copy link
Copy Markdown
Contributor Author

Evan Tahler (evantahler) commented Feb 22, 2023

Thank you Ben Church (@bnchrch) and Pedro S. Lopez (@pedroslopez)!

@evantahler
Copy link
Copy Markdown
Contributor Author

Evan Tahler (evantahler) commented Feb 22, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-exasol

🕑 Publishing the following connectors:
connectors/destination-exasol
https://github.com/airbytehq/airbyte/actions/runs/4244493421


Connector Did it publish? Were definitions generated?
connectors/destination-exasol ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@evantahler Evan Tahler (evantahler) changed the title Fix destination-exasol build Fix destination-exasol build and CatalogDefinition generation Feb 22, 2023
@evantahler Evan Tahler (evantahler) merged commit 8154047 into master Feb 22, 2023
@evantahler Evan Tahler (evantahler) deleted the evan/fix-exasol branch February 22, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroslopez Pedro S. Lopez (pedroslopez) pedroslopez left review comments

@rodireich Rodi Reich Zilberman (rodireich) rodireich approved these changes

@grishick Greg Solovyev (grishick) Awaiting requested review from grishick

@sh4sh sunny (sh4sh) Awaiting requested review from sh4sh

+1 more reviewer

@bnchrch Ben Church (bnchrch) bnchrch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/exasol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@evantahler @rodireich @bnchrch @pedroslopez @octavia-squidington-iii