🐛 Source Microsoft Dataverse: Fixed deduped not working correctly#22805
Merged
Marcos Marx (marcosmarxm) merged 6 commits intoairbytehq:masterfrom Mar 16, 2023
Merged
Conversation
Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Marcelo Castro (marcelopio)
changed the title
Marcelo Castro (marcelopio)
changed the title
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Contributor
|
/publish connector=connectors/source-microsoft-dataverse run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Contributor
|
This is an alpha connector and we don't have credentials yet because of this publishing without testing. Waiting for https://github.com/airbytehq/airbyte-internal-issues/issues/2645 |
Marcos Marx (marcosmarxm)
approved these changes
Mar 16, 2023
Adrienne Vermorel (adriennevermorel)
pushed a commit
to adriennevermorel/airbyte
that referenced
this pull request
Mar 17, 2023
…rbytehq#22805) * Fixed dedupeot working correctly Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end * bump connector version * auto-bump connector version --------- Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: Marcos Marx <[email protected]>
Ella Rohm-Ensing (erohmensing)
pushed a commit
that referenced
this pull request
Mar 22, 2023
…2805) * Fixed dedupeot working correctly Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end * bump connector version * auto-bump connector version --------- Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: Marcos Marx <[email protected]>
Ella Rohm-Ensing (erohmensing)
pushed a commit
that referenced
this pull request
Mar 22, 2023
…2805) * Fixed dedupeot working correctly Due to delete only containing id, the deduped dbt could not work properly, so we also fill the cursor field with the current date so it does have a properly end * bump connector version * auto-bump connector version --------- Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]> Co-authored-by: Marcos Marx <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Due to delete only containing id, the deduped dbt could not work properly, because to check the start and end dates, deduped needs the cursor field to also be filled
How
Fill the cursor field with the current date so it does have a properly end
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes