Skip to content

🎉 New Destination: Exasol#21200

Merged
sunny (sh4sh) merged 70 commits intoairbytehq:masterfrom
kaklakariada:add-exasol-connector
Feb 21, 2023
Merged

🎉 New Destination: Exasol#21200
sunny (sh4sh) merged 70 commits intoairbytehq:masterfrom
kaklakariada:add-exasol-connector

Conversation

@kaklakariada
Copy link
Copy Markdown
Contributor

@kaklakariada Christoph Pirkl (kaklakariada) commented Jan 10, 2023 •
edited by sh4sh
Loading

What

This adds a connector for the Exasol database as destination. This PR replaces #20368 which did not allow edits and access to secrets by maintainers.

How

Created connector based on template.

Recommended reading order

  1. ExasolDestination.java
  2. ExasolSqlOperations.java
  3. ExasolDestinationAcceptanceTest.java

🚨 User Impact 🚨

New Exasol destination in Airbyte.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For the Exasol connector run ./gradlew :airbyte-integrations:connectors:destination-exasol:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/destination/exasol.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit tests and integration/acceptance tests run during CI. No special setup is required:

./gradlew :airbyte-integrations:connectors:destination-exasol:test :airbyte-integrations:connectors:destination-exasol:integrationTest

@ThomasBestfleisch
initial Exasol connector stub
0361e13
@ThomasBestfleisch
CUrrent version
8cb3024
@ThomasBestfleisch
Exasol connector current version
7293429
@ThomasBestfleisch
Exasol connector current version
2090fce
@ThomasBestfleisch
Exasol connector current version
e3de8b2
@ThomasBestfleisch
Exasol connector current version
e771f86
@kaklakariada
Merge remote-tracking branch 'origin/master' into add-exasol-connector
d5ad3c4
@kaklakariada
Merge remote-tracking branch 'origin/master' into add-exasol-connector
0cfae9b
@kaklakariada
Merge remote-tracking branch 'upstream/master' into add-exasol-connector
cfbdda7
@kaklakariada
Remove unwanted changes
02c7f2d
@kaklakariada
Upgrade dependencies
d3d9586
@kaklakariada
Merge remote-tracking branch 'upstream/master' into add-exasol-connector
d25ae28
@kaklakariada
Use Exasol container for integration tests
b069277
@kaklakariada
Merge remote-tracking branch 'origin/master' into add-exasol-connector
1ebfbd4
@kaklakariada
Purge database before test
647b962
@kaklakariada
Merge branch 'master' into add-exasol-connector
2039860
@kaklakariada
Merge branch 'master' into add-exasol-connector
4a22f1d
@kaklakariada
Fix integration tests
430b415
@kaklakariada
Merge remote-tracking branch 'origin/add-exasol-connector' into add-e…
8cd79a4 
…xasol-connector
@kaklakariada
Adapt to new API
76587af
@kaklakariada
Fix integration tests
4e6d66d
@kaklakariada
Merge branch 'master' into add-exasol-connector
843d85f
@kaklakariada
Use separate fields for host, port and fingerprint
bae7b7a
@kaklakariada
Merge branch 'master' into add-exasol-connector
5c8ce2e
@kaklakariada
Deactivate action on forks
d346c8e
@kaklakariada Christoph Pirkl (kaklakariada) changed the title Add exasol connector New Destination: Exasol Jan 10, 2023
@kaklakariada
Copy link
Copy Markdown
Contributor Author

Christoph Pirkl (kaklakariada) commented Jan 23, 2023

Ivica Taseski (@itaseskii) I implemented your comments, please check again.

@itaseskii
Copy link
Copy Markdown
Contributor

Ivica Taseski (itaseskii) commented Jan 25, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/destination-exasol

🕑 connectors/destination-exasol https://github.com/airbytehq/airbyte/actions/runs/4004559668
✅ connectors/destination-exasol https://github.com/airbytehq/airbyte/actions/runs/4004559668
No Python unittests run

Build Passed

Test summary info:

All Passed

@itaseskii
Copy link
Copy Markdown
Contributor

Ivica Taseski (itaseskii) commented Jan 30, 2023

Nice work Christoph Pirkl (@kaklakariada)! I have approved your changes and I will proceed with the release process.

@itaseskii Ivica Taseski (itaseskii) mentioned this pull request Feb 6, 2023
Closed
@sh4sh
Copy link
Copy Markdown
Contributor

sunny (sh4sh) commented Feb 7, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-exasol

🕑 Publishing the following connectors:
connectors/destination-exasol
https://github.com/airbytehq/airbyte/actions/runs/4117243984


Connector Did it publish? Were definitions generated?
connectors/destination-exasol ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@sh4sh sunny (sh4sh) mentioned this pull request Feb 7, 2023
Closed
@sh4sh sunny (sh4sh) temporarily deployed to more-secrets February 7, 2023 23:26 — with GitHub Actions Inactive
@sh4sh sunny (sh4sh) temporarily deployed to more-secrets February 7, 2023 23:26 — with GitHub Actions Inactive
@kaklakariada
Copy link
Copy Markdown
Contributor Author

Christoph Pirkl (kaklakariada) commented Feb 21, 2023

Ivica Taseski (@itaseskii) sunny (@sh4sh) Greg Solovyev (@grishick) : When will this PR be merged? Can I do anything to help?

@sh4sh sunny (sh4sh) merged commit f9bc114 into airbytehq:master Feb 21, 2023
@sh4sh
Copy link
Copy Markdown
Contributor

sunny (sh4sh) commented Feb 21, 2023

Thanks for your contribution!

@evantahler
Copy link
Copy Markdown
Contributor

Evan Tahler (evantahler) commented Feb 22, 2023 •
edited
Loading

sunny (@sh4sh) - this PR should not have been merged as it did not pass the branch requirements. Now the master branch is also failing too. The /publish command above also failed. I'm going to revert this PR.

Edit: I think I know what's wrong - trying to fix it. Check out #23321!

Evan Tahler (evantahler) added a commit that referenced this pull request Feb 22, 2023
@evantahler
Revert "🎉 New Destination: Exasol (#21200)"
a3a3bb5 
This reverts commit f9bc114.
This was referenced Feb 22, 2023
Closed
Merged
@kaklakariada Christoph Pirkl (kaklakariada) deleted the add-exasol-connector branch February 22, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@ckunki Christoph Kuhnke (ckunki) ckunki requested changes

@grishick Greg Solovyev (grishick) grishick approved these changes

@sh4sh sunny (sh4sh) sh4sh approved these changes

@itaseskii Ivica Taseski (itaseskii) itaseskii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@itaseskii Ivica Taseski (itaseskii)

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/destination/exasol

Projects

No open projects
Community Contributed PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kaklakariada @itaseskii @sh4sh @evantahler @grishick @ckunki @octavia-squidington-iv @ThomasBestfleisch