Skip to content

🎉 New Destination: Exasol#20368

Closed
Christoph Pirkl (kaklakariada) wants to merge 25 commits intoairbytehq:masterfrom
exasol:add-exasol-connector
Closed

🎉 New Destination: Exasol#20368
Christoph Pirkl (kaklakariada) wants to merge 25 commits intoairbytehq:masterfrom
exasol:add-exasol-connector

Conversation

@kaklakariada
Copy link
Copy Markdown
Contributor

@kaklakariada Christoph Pirkl (kaklakariada) commented Dec 12, 2022 •
edited
Loading

What

This adds a connector for the Exasol database as destination.

How

Created connector based on template.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

New Exasol destination in Airbyte

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@kaklakariada Christoph Pirkl (kaklakariada) marked this pull request as draft December 12, 2022 15:14
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kaklakariada Christoph Pirkl (kaklakariada) marked this pull request as ready for review December 16, 2022 12:11
@sajarin Sajarin (sajarin) added the bounty-XL Maintainer program: claimable extra large bounty PR label Dec 19, 2022
@sajarin Sajarin (sajarin) changed the title Add Exasol destination connector 🎉 New Destination: Exasol Dec 19, 2022
@marcosmarxm
Copy link
Copy Markdown
Contributor

Marcos Marx (marcosmarxm) commented Dec 20, 2022

Hello 👋:skin-tone-2: and thank you for your contribution!

Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays.
Because of this, reviewing and merging your contribution may take longer than usual.
We apologize for the delay, but we want everyone to have a quiet and happy holiday.

If you have any questions or need further clarification, please don't hesitate to ping via Slack.

@itaseskii
Copy link
Copy Markdown
Contributor

Ivica Taseski (itaseskii) commented Dec 21, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-exasol

🕑 connectors/destination-exasol https://github.com/airbytehq/airbyte/actions/runs/3751083140

@itaseskii
Copy link
Copy Markdown
Contributor

Ivica Taseski (itaseskii) commented Jan 9, 2023

/test connector=connectors/destination-exasol

@itaseskii
Copy link
Copy Markdown
Contributor

Ivica Taseski (itaseskii) commented Jan 9, 2023 •
edited
Loading

Hey Christoph Pirkl (@kaklakariada) have you allowed edits and access to secrets by maintainers on the PR? :)
image

@kaklakariada
Copy link
Copy Markdown
Contributor Author

Christoph Pirkl (kaklakariada) commented Jan 10, 2023

Hi Ivica Taseski (@itaseskii), I tried that but this option is not available. According to the documentation:

Who can use this feature
People with push access to the upstream repository of a fork owned by a personal account can commit to the forked branches.

I guess the problem is the "personal account", because exasol is an org. I will fork the repo into my personal account and create another PR.

Merged
18 tasks
@kaklakariada
Copy link
Copy Markdown
Contributor Author

Christoph Pirkl (kaklakariada) commented Jan 10, 2023

I created #21200 from my personal fork and allowed editing.
This PR is now not necessary any more.

@itaseskii Ivica Taseski (itaseskii) mentioned this pull request Jan 10, 2023
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itaseskii Ivica Taseski (itaseskii) Awaiting requested review from itaseskii

Assignees

@itaseskii Ivica Taseski (itaseskii)

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty bounty-XL Maintainer program: claimable extra large bounty PR community connectors/destination/exasol

Projects

No open projects
Community Contributed PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kaklakariada @CLAassistant @marcosmarxm @itaseskii @sajarin @octavia-squidington-iv @ThomasBestfleisch