🎉 New Source: Unleash [low-code CDK] by arnaudselva · Pull Request #19923 · airbytehq/airbyte

arnaudselva · 2022-11-30T15:34:29Z

What

Creates a source for the Unleash API : a popular open source feature management product.
Issue Reference: New Source: Unleash [low-code CDK] #19877

How

Using the low-code CDK.

🚨 User Impact 🚨

No breaking change

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Integration

Acceptance

See above

CLAassistant · 2022-11-30T15:34:35Z

All committers have signed the CLA.

…arnaudselva-source-unleash

Marcos Marx (marcosmarxm)

Some comments, do you have a sandbox account to run integration tests?

airbyte-integrations/connectors/source-unleash/source_unleash/spec.yaml

airbyte-integrations/connectors/source-unleash/source_unleash/unleash.yaml

arnaudselva · 2022-12-02T23:00:47Z

Some comments, do you have a sandbox account to run integration tests?

Marcos Marx (@marcosmarxm) thanks! sure I can share with you an endpoint and a temporary api token, where do you want me to share them with you?

Marcos Marx (marcosmarxm) · 2022-12-20T19:52:28Z

Hello 👋:skin-tone-2: and thank you for your contribution!

Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays.
Because of this, reviewing and merging your contribution may take longer than usual.
We apologize for the delay, but we want everyone to have a quiet and happy holiday.

If you have any questions or need further clarification, please don't hesitate to ping via Slack.

arnaudselva · 2023-01-18T14:20:35Z

hello hello, would it be possible to get an ETA on a possible review of this PR? Thanks in advance.

Iryna Grankova (igrankova) · 2023-01-27T15:15:22Z

The Support team assigned a "PRO" instance in the US cluster, that is now set to not expire.
The API Token is generated and stored in the Notes area, the link to the screen: https://us.app.unleash-hosted.com/ushh0019/admin/api
LastPass name: Unleash Sandbox Account
cc Nataly Merezhuk (@natalyjazzviolin), I've closed the sandbox request issue as completed, let me know if I can help with anything else here. We have a full support from the Unleash team and I can contact them.

Iryna Grankova (igrankova) · 2023-01-31T09:02:07Z

arnaudselva, I had a talk with the Unleash support and they are happy to provide any help and information for this integration.

arnaudselva · 2023-01-31T10:58:03Z

arnaudselva, I had a talk with the Unleash support and they are happy to provide any help and information for this integration.

Iryna Grankova (@igrankova) nice, thanks. I think there is only an open question to know if the API has pagination or not (I did the implementation without any pagination logic).

Iryna Grankova (igrankova) · 2023-01-31T11:19:17Z

arnaudselva I sent this question to the support, because I haven't find it in the docs. So I'll let you know when receive an answer.
Unleash team also asked me to let them know when we finish this connector. They want to test it.

Iryna Grankova (igrankova) · 2023-02-01T13:15:42Z

arnaudselva, the answer from Unleash:
"Only a few of the APIs support pagination today (when it makes sense, eg.g. the event search API).

Do you happen to know which API endpoint is relevant?"

arnaudselva · 2023-02-01T13:25:05Z

arnaudselva, the answer from Unleash: "Only a few of the APIs support pagination today (when it makes sense, eg.g. the event search API).

Do you happen to know which API endpoint is relevant?"

Iryna Grankova (@igrankova) we are only relying on the client API : https://docs.getunleash.io/reference/api/legacy/unleash/client/features.
I don't have any use case for the other APIs (as it has more to do with managing Unleash rather than reporting). But happy to consider those other APIs on a future iteration of the source (if some people arouse their interest).
For our use case no pagination then, thanks

sunny (sh4sh) · 2023-02-23T18:43:00Z

Changed refs and formatting to conform with breaking changes in airbyte-cdk 0.29.0 (changelog)

sunny (sh4sh)

Left some comments and suggestions, let me know if anything was unclear

airbyte-integrations/connectors/source-unleash/integration_tests/sample_config.json

airbyte-integrations/connectors/source-unleash/source_unleash/unleash.yaml

airbyte-integrations/connectors/source-unleash/source_unleash/spec.yaml

airbyte-integrations/connectors/source-unleash/source_unleash/unleash.yaml

…unleash.yaml Co-authored-by: Sunny <[email protected]>

…spec.yaml Co-authored-by: Sunny <[email protected]>

…unleash.yaml Co-authored-by: Sunny <[email protected]>

arnaudselva · 2023-02-24T09:02:58Z

sunny (@sh4sh) thank you for your feedback 🙏 I did the changes, let me know what you think

sunny (sh4sh) · 2023-03-08T18:03:29Z

Added creds to GSM, running integration tests here: #23394 (comment)

Changes are resolved, dismissing review so we can publish and merge.

sunny (sh4sh) · 2023-03-08T20:07:37Z

/publish connector=connectors/source-unleash

🕑 Publishing the following connectors:
connectors/source-unleash
https://github.com/airbytehq/airbyte/actions/runs/4368104300

Connector	Did it publish?	Were definitions generated?
connectors/source-unleash	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sunny (sh4sh) · 2023-03-09T13:54:19Z

arnaudselva thanks for your contribution!

* 🎉 New Source: Unleash [low-code CDK] * update unleash.md with pull request number * add bootstrap.md * remove "optional" mention in the spec descriptions * fix formatting and update source-acceptance-test to connector-acceptance-test * update to low-code framework update in airbyte-cdk 0.29.0 * Update airbyte-integrations/connectors/source-unleash/source_unleash/unleash.yaml Co-authored-by: Sunny <[email protected]> * Update airbyte-integrations/connectors/source-unleash/source_unleash/spec.yaml Co-authored-by: Sunny <[email protected]> * Update airbyte-integrations/connectors/source-unleash/source_unleash/unleash.yaml Co-authored-by: Sunny <[email protected]> * adjusting naming * add source-unleash connector icon * add icon to source_definitions.yaml * auto-bump connector version --------- Co-authored-by: Sajarin <[email protected]> Co-authored-by: Sunny <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>

🎉 New Source: Unleash [low-code CDK]

7c7e31e

Octavia Squidington IV (octavia-squidington-iv) added area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/unleash labels Nov 30, 2022

arnaudselva and others added 5 commits November 30, 2022 16:52

update unleash.md with pull request number

2a72e13

Merge branch 'master' of https://github.com/arnaudselva/airbyte into …

997731a

…arnaudselva-source-unleash

Merge branch 'master' into arnaudselva-source-unleash

63d5103

add bootstrap.md

d5d84f4

Merge branch 'master' into arnaudselva-source-unleash

6cf83da

Marcos Marx (marcosmarxm) previously requested changes Dec 2, 2022

View reviewed changes

arnaudselva and others added 2 commits December 3, 2022 00:01

remove "optional" mention in the spec descriptions

e6766ff

Merge branch 'master' into arnaudselva-source-unleash

c187589

Sajarin (sajarin) added the bounty-XL Maintainer program: claimable extra large bounty PR label Dec 5, 2022

arnaudselva requested a review from Marcos Marx (marcosmarxm) January 18, 2023 14:18

Nataly Merezhuk (natalyjazzviolin) mentioned this pull request Jan 23, 2023

Sandbox Account for Unleash API #21706

Closed

Merge branch 'master' into arnaudselva-source-unleash

eb1500e

Merge branch 'master' into arnaudselva-source-unleash

5e90f85

Merge branch 'master' into arnaudselva-source-unleash

d6f2f4f

update to low-code framework update in airbyte-cdk 0.29.0

6cfcdb3

sunny (sh4sh) reviewed Feb 23, 2023

View reviewed changes

arnaudselva and others added 4 commits February 24, 2023 09:47

Update airbyte-integrations/connectors/source-unleash/source_unleash/…

81bde48

…unleash.yaml Co-authored-by: Sunny <[email protected]>

Update airbyte-integrations/connectors/source-unleash/source_unleash/…

8ef7f7e

…spec.yaml Co-authored-by: Sunny <[email protected]>

Update airbyte-integrations/connectors/source-unleash/source_unleash/…

850b2c2

…unleash.yaml Co-authored-by: Sunny <[email protected]>

adjusting naming

241feb9

arnaudselva added 2 commits March 1, 2023 18:35

Merge branch 'master' into arnaudselva-source-unleash

309e78b

Merge branch 'master' into arnaudselva-source-unleash

832af5b

arnaudselva requested review from sunny (sh4sh) and removed request for Marcos Marx (marcosmarxm) March 2, 2023 10:49

sunny (sh4sh) added 2 commits March 8, 2023 12:51

add source-unleash connector icon

e2a9fe0

add icon to source_definitions.yaml

c7e66c2

sunny (sh4sh) approved these changes Mar 8, 2023

View reviewed changes

sunny (sh4sh) requested a review from Marcos Marx (marcosmarxm) March 8, 2023 20:01

Merge branch 'master' into arnaudselva-source-unleash

bcae748

auto-bump connector version

9d18a0e

sunny (sh4sh) enabled auto-merge (squash) March 8, 2023 20:27

Merge branch 'master' into arnaudselva-source-unleash

7da85e6

sunny (sh4sh) disabled auto-merge March 8, 2023 21:17

Merge branch 'master' into arnaudselva-source-unleash

79656b2

sunny (sh4sh) enabled auto-merge (squash) March 9, 2023 13:34

sunny (sh4sh) merged commit 8324098 into airbytehq:master Mar 9, 2023

Comments

Conversation

arnaudselva commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

Uh oh!

CLAassistant commented Nov 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marcos Marx (marcosmarxm) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arnaudselva commented Dec 2, 2022

Uh oh!

Marcos Marx (marcosmarxm) commented Dec 20, 2022

Uh oh!

arnaudselva commented Jan 18, 2023

Uh oh!

Iryna Grankova (igrankova) commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Iryna Grankova (igrankova) commented Jan 31, 2023

Uh oh!

arnaudselva commented Jan 31, 2023

Uh oh!

Iryna Grankova (igrankova) commented Jan 31, 2023

Uh oh!

Iryna Grankova (igrankova) commented Feb 1, 2023

Uh oh!

arnaudselva commented Feb 1, 2023

Uh oh!

sunny (sh4sh) commented Feb 23, 2023

Uh oh!

sunny (sh4sh) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arnaudselva commented Feb 24, 2023

Uh oh!

sunny (sh4sh) commented Mar 8, 2023

Uh oh!

sunny (sh4sh) commented Mar 8, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sunny (sh4sh) commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

arnaudselva commented Nov 30, 2022 •

edited

Loading

CLAassistant commented Nov 30, 2022 •

edited

Loading

Iryna Grankova (igrankova) commented Jan 27, 2023 •

edited

Loading

sunny (sh4sh) commented Mar 8, 2023 •

edited by github-actions bot

Loading