🎉 New Source: Microsoft Dataverse [python cdk] by danilo-dti · Pull Request #18646 · airbytehq/airbyte

Danilo Siqueira (danilo-dti) · 2022-10-29T01:07:57Z

What

Implementing Microsoft Dataverse API:
https://learn.microsoft.com/en-us/power-apps/developer/data-platform/webapi/overview

How

Using Airbyte CDK Python HTTP API.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-10-29T01:08:07Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ danilo-dti
✅ marcelopio
✅ marcosmarxm
❌ daniloss99
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Marcos Marx (marcosmarxm)

Hello Danilo Siqueira (@danilo-dti) , Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

Marcos Marx (marcosmarxm)

A few comments beside my last message. Would be nice to have a test account to run some tests for this complex source.

Marcos Marx (marcosmarxm) · 2022-10-31T20:34:32Z

...e-integrations/connectors/source-microsoft-dataverse/source_microsoft_dataverse/dataverse.py

+    if dataverse_type == "String":
+        attribute_type = {"type": ["null", "string"]}
+    elif dataverse_type == "DateTime":
+        attribute_type = {"type": ["null", "string"], "format": "date-time", "airbyte_type": "timestamp_with_timezone"}
+    elif dataverse_type == "Integer":
+        attribute_type = {"type": ["null", "integer"]}
+    elif dataverse_type == "Money":
+        attribute_type = {"type": ["null", "number"]}
+    elif dataverse_type == "Boolean":
+        attribute_type = {"type": ["null", "boolean"]}
+    elif dataverse_type == "Double":
+        attribute_type = {"type": ["null", "number"]}
+    elif dataverse_type == "Decimal":
+        attribute_type = {"type": ["null", "number"]}
+    elif dataverse_type == "Virtual":
+        return None


What about having an Enum class?

Done, I don't know if is how you imagined it, but I think the code is better.

Marcos Marx (marcosmarxm) · 2022-10-31T20:36:03Z

...yte-integrations/connectors/source-microsoft-dataverse/source_microsoft_dataverse/streams.py

+    def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
+        response_json = response.json()
+        if "@odata.deltaLink" in response_json:


please add unit test

Danilo Siqueira (danilo-dti) · 2022-11-03T15:02:17Z

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

All done.

…o-dti/airbyte into source-microsoft-dataverse

Marcos Marx (marcosmarxm) · 2022-11-04T08:55:33Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

Marcos Marx (marcosmarxm) · 2022-11-07T22:44:11Z

Danilo Siqueira (@danilo-dti) I won't have time to review your contribution today. I added it to my tomorrow's priority list.

Marcos Marx (marcosmarxm) · 2022-11-10T23:39:22Z

Danilo Siqueira (@danilo-dti) can you share the output of ./gradlew airbyte-integrations:connectors:source-microsoft-dataverse:integrationTest?

Danilo Siqueira (danilo-dti) · 2022-11-12T19:54:30Z

Danilo Siqueira (@danilo-dti) can you share the output of ./gradlew airbyte-integrations:connectors:source-microsoft-dataverse:integrationTest?

Attaching the file below.

integration_test_output.txt

Marcos Marx (marcosmarxm) · 2022-11-14T11:30:50Z

/publish connector=connectors/source-microsoft-dataverse run-tests=false

🕑 Publishing the following connectors:
connectors/source-microsoft-dataverse
https://github.com/airbytehq/airbyte/actions/runs/3461081419

Connector	Did it publish?	Were definitions generated?
connectors/source-microsoft-dataverse	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Marcos Marx (marcosmarxm)

Thanks Danilo Siqueira (@danilo-dti)

Danilo Siqueira (danilo-dti) · 2022-11-14T12:21:26Z

Thanks Marcelo Castro (@marcelopio) for working together and Marcos Marx (@marcosmarxm) for the support.

Chris "Sean" Dabatos (RealChrisSean) · 2022-11-18T18:57:56Z

Hi Danilo Siqueira (@danilo-dti) can you please update your github with your contact email? If you don't want to update your github profile with your email you can also send me a DM on slack with a link to this PR, your full name and email plz :).

Thank you!

* Connector files * Add test files * Add integration test config files * Multiple changes to make it on Airbyte standards * Cleaning up * More clean ups * More clean ups * Removed max pages * Remove unused variable * Correctly separating Full refresh and incremental * Removed unused variables * Fix full_refresh class * Better code for creating stream classes * Fixing review comments * Update docs and Enum class * Update type conversion function * Fix enum class and update docs * Update discover * Implemented some unit tests * Update discover * Update test_source * Increase discovery test timeout * Update configured_catalog * Fix default_cursor_field * Adding final unit tests * Update spec: set client_id and tenant_id as secrets * Update discover to deal with Lookup and Picklist types * Fix Lookup data type conversion * add microsoft dataverse to source def * run format * auto-bump connector version Co-authored-by: Marcelo Pio de Castro <[email protected]> Co-authored-by: daniloss99 <[email protected]> Co-authored-by: Marcos Marx <[email protected]> Co-authored-by: marcosmarxm <[email protected]> Co-authored-by: Octavia Squidington III <[email protected]>

Danilo Siqueira (danilo-dti) and others added 9 commits October 24, 2022 19:50

Connector files

29164ac

Add test files

52dfcf1

Add integration test config files

5bc89de

Multiple changes to make it on Airbyte standards

66ebe56

Cleaning up

167ddb4

More clean ups

269b28a

More clean ups

5b74a86

Removed max pages

f913d5c

Remove unused variable

bf9fb61

github-actions bot added the area/connectors Connector related issues label Oct 29, 2022

Octavia Squidington IV (octavia-squidington-iv) added bounty community connectors/source/microsoft-dataverse labels Oct 29, 2022

Marcos Marx (marcosmarxm) added the hacktober label Oct 30, 2022

Marcelo Castro (marcelopio) added 4 commits October 30, 2022 23:41

Correctly separating Full refresh and incremental

8c9f3f1

Removed unused variables

eeadec0

Fix full_refresh class

79dd28f

Better code for creating stream classes

b35fca5

Marcos Marx (marcosmarxm) suggested changes Oct 31, 2022

View reviewed changes

Marcos Marx (marcosmarxm) changed the title ~~🎉 New Source: Microsoft Dataverse~~ 🎉 New Source: Microsoft Dataverse [python cdk] Oct 31, 2022

Marcos Marx (marcosmarxm) suggested changes Oct 31, 2022

View reviewed changes

Fixing review comments

3dc051b

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 1, 2022

Danilo Siqueira (danilo-dti) and others added 5 commits November 1, 2022 18:35

Update docs and Enum class

2598c57

Update type conversion function

2a38167

Fix enum class and update docs

4cdc47f

Update discover

7886680

Implemented some unit tests

36594e0

Danilo Siqueira (danilo-dti) and others added 6 commits November 3, 2022 12:03

Merge branch 'source-microsoft-dataverse' of https://github.com/danil…

5186afa

…o-dti/airbyte into source-microsoft-dataverse

Update test_source

fed7f36

Increase discovery test timeout

c5d987d

Update configured_catalog

7633259

Fix default_cursor_field

6a0e6de

Adding final unit tests

9a9663f

Danilo Siqueira (danilo-dti) requested a review from Marcos Marx (marcosmarxm) November 7, 2022 22:19

Danilo Siqueira (danilo-dti) and others added 3 commits November 11, 2022 17:47

Update spec: set client_id and tenant_id as secrets

9295a44

Update discover to deal with Lookup and Picklist types

b2759a3

Fix Lookup data type conversion

4914154

Marcos Marx (marcosmarxm) and others added 3 commits November 14, 2022 06:07

Merge branch 'master' into source-microsoft-dataverse

9844bf8

add microsoft dataverse to source def

5224bcc

run format

7b7ea27

Octavia Squidington III (octavia-squidington-iii) and others added 2 commits November 14, 2022 11:44

auto-bump connector version

a1337c8

Merge branch 'master' into source-microsoft-dataverse

a783135

Marcos Marx (marcosmarxm) approved these changes Nov 14, 2022

View reviewed changes

Marcos Marx (marcosmarxm) merged commit 7ca371b into airbytehq:master Nov 14, 2022

Chris "Sean" Dabatos (RealChrisSean) added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

Octavia Squidington III (octavia-squidington-iii) mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Sajarin (sajarin) added internal and removed bounty labels Dec 5, 2022

Comments

Conversation

Danilo Siqueira (danilo-dti) commented Oct 29, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

Uh oh!

CLAassistant commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marcos Marx (marcosmarxm) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marcos Marx (marcosmarxm) left a comment

Choose a reason for hiding this comment

Uh oh!

Marcos Marx (marcosmarxm) Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

Marcelo Castro (marcelopio) Nov 3, 2022

Choose a reason for hiding this comment

Uh oh!

Marcos Marx (marcosmarxm) Oct 31, 2022

Choose a reason for hiding this comment

Uh oh!

Marcelo Castro (marcelopio) Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

Danilo Siqueira (danilo-dti) commented Nov 3, 2022

Uh oh!

Marcos Marx (marcosmarxm) commented Nov 4, 2022

Uh oh!

Marcos Marx (marcosmarxm) commented Nov 7, 2022

Uh oh!

Marcos Marx (marcosmarxm) commented Nov 10, 2022

Uh oh!

Danilo Siqueira (danilo-dti) commented Nov 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marcos Marx (marcosmarxm) commented Nov 14, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marcos Marx (marcosmarxm) left a comment

Choose a reason for hiding this comment

Uh oh!

Danilo Siqueira (danilo-dti) commented Nov 14, 2022

Uh oh!

Chris "Sean" Dabatos (RealChrisSean) commented Nov 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

CLAassistant commented Oct 29, 2022 •

edited

Loading

Marcos Marx (marcosmarxm) left a comment •

edited

Loading

Danilo Siqueira (danilo-dti) commented Nov 12, 2022 •

edited

Loading

Marcos Marx (marcosmarxm) commented Nov 14, 2022 •

edited by github-actions bot

Loading