[eslint config] [*] [new] add eslint v7#2240
Merged
ljharb merged 1 commit intoairbnb:masterfrom Jun 10, 2020
Merged
Conversation
Collaborator
|
Thanks, I already have this branch locally tho and it'll require a bit more than this. I'll repurpose the PR. |
12 tasks
ljharb
changed the title
eslint v7
12 tasks
3 tasks
keann
reviewed
Jul 21, 2020
| // Disallow assignments that can lead to race conditions due to usage of await or yield | ||
| // https://eslint.org/docs/rules/require-atomic-updates | ||
| // TODO: enable, semver-major | ||
| // note: not enabled because it is very buggy |
There was a problem hiding this comment.
Hi, @ljharb !
Would you mind to share some cases where you faced bugs in this rule?
Collaborator
There was a problem hiding this comment.
There’s a couple threads on eslint core that are full of examples; i don’t have any off hand.
There was a problem hiding this comment.
right, might have guessed myself to look there. thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @ljharb