Align class names with current functionality#1152
Merged
Conversation
Since the enum is part of the BlockHeader interface, it does not need
a long name to relate to block.
Also renamed the enum items as follows:
- SEAL_NA to NOT_APPLICABLE
- SEAL_POW_BLOCK to PROOF_OF_WORK
- SEAL_POS_BLOCK to PROOF_OF_STAKE
This remaning is meant to reduce visual confusion when dealing with
the POS and POW seal types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change