AKI-353: Combine the batch and direct write functionality#1147
Merged
AlexandraRoatis merged 8 commits intomasterfrom Apr 20, 2020
Merged
AKI-353: Combine the batch and direct write functionality#1147AlexandraRoatis merged 8 commits intomasterfrom
AlexandraRoatis merged 8 commits intomasterfrom
Conversation
While it may offer minor optimizations when used for LevelDB and RocksDB the class was not correctly maintained and lacks functionality. Further, it is currently not necessary to use locked databases in production so it is not worth keeping the class. It can be re-added with full correct implementation when it is truly needed and proven to improve performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change