Merged
Conversation
AionJayT
reviewed
Mar 20, 2020
| } | ||
|
|
||
| if (currentBlock % stepSize == 0) { | ||
| double time = System.currentTimeMillis() - start; |
Collaborator
There was a problem hiding this comment.
I prefer the calculation to use long directly. Even it has a little rounding issue.
But we can refactor it in a new task.
The estimate can be represent by TimeUnit conversion.
Contributor
Author
There was a problem hiding this comment.
added a Jira task for this and enhancing the time estimates
AionJayT
reviewed
Mar 20, 2020
| } | ||
|
|
||
| public static Cli.ReturnType printAccountDetails(String strAddress) { | ||
| // TODO: more parameters would be useful, e.g. get account X at block Y |
Collaborator
There was a problem hiding this comment.
Convert TODO to a Jira ticket.
AionJayT
approved these changes
Mar 20, 2020
Collaborator
AionJayT
left a comment
AionJayT
left a comment
There was a problem hiding this comment.
LGTM, only few comments can be the future tasks
AlexandraRoatis
force-pushed
the
AKI-679
branch
from
6d92cfc to
48e6d3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change