Conversation
AlexandraRoatis
added
bug
AlexandraRoatis
force-pushed
the
AKI-667
branch
from
47d415a to
f22f114
Compare
AlexandraRoatis
force-pushed
the
AKI-667
branch
2 times, most recently
from
791d086 to
1ac3547
Compare
| db.commit(); | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
What scenario we will see the databaseGroup equal to null ? Sometimes We can see this message during the seednode running, also the project test case.
There was a problem hiding this comment.
The databaseGroup is null when using a repository snapshot. The snapshot is always used when importing a side chain block. The message is really useless, cause it doesn't notify us of anything meaningful.
AionJayT
left a comment
AionJayT
left a comment
There was a problem hiding this comment.
LGTM, only one question for the databasegroup null case.
| try { | ||
| blockTemplate = blockchain.createStakingBlockTemplate( | ||
| mempool.getPendingTransactions(), signingPublicKey, newSeed, coinbase); | ||
| blockTemplate = blockchain.createStakingBlockTemplate(best, mempool.getPendingTransactions(), signingPublicKey, newSeed, coinbase); |
There was a problem hiding this comment.
Should we just use blockTemplateLock and the try...finally to include all of the method?
Same as the getMiningBlockTemplate
There was a problem hiding this comment.
I added an extra commit for this change.
These are accounts for producing transactions that are not involved in staking.
JournalPruneDataSource already rolls back the side chain blocks.
The staking blocks were always created on top of the best block. This is a valid setup for the staker tools but it prevents testing the functionality with side chains. Additionally, this is a bug fix for AionHub. The hub could cause incorrect block creation due to the fact that it was calling the getBestBlock method in the blockchain twice without synchronization. This bug fix may relate to AKI-657.
The test is ignored for now pending the fix for AKI-677.
AlexandraRoatis
force-pushed
the
AKI-667
branch
from
388ae1e to
ee8c73b
Compare
2 participants
Type of change