Conversation
AionJayT
force-pushed
the
shutdown-fix
branch
2 times, most recently
from
da7c1ae to
08e4c58
Compare
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
Contributor
AlexandraRoatis
left a comment
AlexandraRoatis
left a comment
There was a problem hiding this comment.
Is the second commit still necessary? Wouldn't the re-entrant lock prevent any deadlocks? Also, in the past there have been very big objections to expanding the ImportResult enum.
|
|
||
| private SelfNodeStatusCallback callback; | ||
| private BestBlockImportCallback bestBlockCallback; | ||
| ReentrantLock blockChainCoreLock = new ReentrantLock(); |
Contributor
There was a problem hiding this comment.
minor: I would call it simply lock
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
modAionImpl/src/org/aion/zero/impl/blockchain/AionBlockchainImpl.java
Outdated
Show resolved
Hide resolved
| LOG.debug("BestStakingBlock {}", bestStakingBlock.toString()); | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("BestBlock {}", bestBlock.toString()); | ||
| if (bestMiningBlock != null) { |
Contributor
There was a problem hiding this comment.
Can we omit the null checks and the .toString in each of the messages?
modAionImpl/src/org/aion/zero/impl/blockchain/StandaloneBlockchain.java
Outdated
Show resolved
Hide resolved
AlexandraRoatis
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue # .
Type of change
Testing