Skip to content

ContractDetails refactoring and testing#1108

Merged
AlexandraRoatis merged 17 commits intomasterfrom
AKI-435
Jan 30, 2020
Merged

ContractDetails refactoring and testing#1108
AlexandraRoatis merged 17 commits intomasterfrom
AKI-435

Conversation

@AlexandraRoatis
Copy link
Copy Markdown
Contributor

@AlexandraRoatis AlexandraRoatis commented Jan 22, 2020

  • Reduced some of the complexity of the AionContractDetailsImpl.
  • Benchmarked the utility of the storage transition.

@AlexandraRoatis AlexandraRoatis added the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 22, 2020
@AlexandraRoatis AlexandraRoatis self-assigned this Jan 22, 2020
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-435 branch 10 times, most recently from 0608efe to 2880284 Compare January 28, 2020 20:56
@AlexandraRoatis AlexandraRoatis force-pushed the AKI-435 branch 2 times, most recently from 07a371d to 0608efe Compare January 29, 2020 15:38
@AlexandraRoatis AlexandraRoatis changed the title WIP - AKI-435 ContractDetails refactoring and testing Jan 29, 2020
@AlexandraRoatis AlexandraRoatis added enhancement New feature or request unit tests labels Jan 29, 2020
@AlexandraRoatis AlexandraRoatis added this to the 1.3 milestone Jan 29, 2020
@AlexandraRoatis AlexandraRoatis removed the wip Indicates that a PR or issue is Work In Progress, issuer should be notified before any actions label Jan 29, 2020
 - detailsInMemoryStorageLimit converted to static and tagged as @VisibleForTesting;
 - removed unnecessary use of detailsInMemoryStorageLimit.
…timisation):

 - replace test specific method setExternalStorageDataSource with more restrictive option;
 - corrected testExternalStorageTransition to test the actual transition functionality;
 - storing the encoding increases the complexity of the code with very little benefit;
 - the encoding is computed only once at commit, but copied many times if cached;
@AlexandraRoatis AlexandraRoatis merged commit e5f8416 into master Jan 30, 2020
@AlexandraRoatis AlexandraRoatis deleted the AKI-435 branch January 30, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants