ContractDetails refactoring and testing#1108
Merged
AlexandraRoatis merged 17 commits intomasterfrom Jan 30, 2020
Merged
Conversation
0608efe to
2880284
Compare
AionJayT
reviewed
Jan 29, 2020
modAionImpl/test/org/aion/zero/impl/db/AionContractDetailsTest.java
Outdated
Show resolved
Hide resolved
07a371d to
0608efe
Compare
9b60f9a to
d2b7cb2
Compare
…g is one way only.
- detailsInMemoryStorageLimit converted to static and tagged as @VisibleForTesting; - removed unnecessary use of detailsInMemoryStorageLimit.
…timisation): - replace test specific method setExternalStorageDataSource with more restrictive option; - corrected testExternalStorageTransition to test the actual transition functionality;
- storing the encoding increases the complexity of the code with very little benefit; - the encoding is computed only once at commit, but copied many times if cached;
- shows that storage transition is more expensive (in time and db size) than the alternative.
67b41c5 to
e05195d
Compare
e05195d to
e5f8416
Compare
AionJayT
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AionContractDetailsImpl.