Fix review issues from PR #1761#1762
Merged
JrooTJunior merged 3 commits intoaiogram:feature/api-9.4from Feb 10, 2026
Merged
Conversation
Latand
force-pushed
the
fix/api-9.4-review-fixes
branch
from
0e91922 to
27bf725
Compare
- Remove stray '-' artifact from GameHighScore docstring - Fix Makefile reformat target scope inconsistency (ruff check --fix) - Add User.get_profile_audios() shortcut method (parallel to get_profile_photos) - Test ChatOwnerLeft with new_owner=None (edge case) - Add VideoQuality type and Video.qualities nesting tests - Add User.get_profile_audios() test Co-Authored-By: Claude Opus 4.6 <[email protected]>
Latand
force-pushed
the
fix/api-9.4-review-fixes
branch
from
27bf725 to
9acc441
Compare
✔️ Changelog found.Thank you for adding a description of the changes |
Olegt0rr
suggested changes
Feb 10, 2026
Contributor
Olegt0rr
left a comment
Olegt0rr
left a comment
There was a problem hiding this comment.
LGTM, but with minor code smells in tests
Olegt0rr
suggested changes
Feb 10, 2026
…gelog Co-Authored-By: Claude Opus 4.6 <[email protected]>
JrooTJunior
approved these changes
Feb 10, 2026
JrooTJunior
approved these changes
Feb 10, 2026
JrooTJunior
added a commit
that referenced
this pull request
Feb 10, 2026
* Bump API schema to version 9.4, add new object types, methods, and properties. * Add tests for `ChatOwnerChanged` and `ChatOwnerLeft` message types * Add tests for `GetUserProfileAudios`, `RemoveMyProfilePhoto`, and `SetMyProfilePhoto` methods * Bump version * Update Makefile variables and refactor `test_get_user_profile_audios.py` * Document new features and updates from Bot API 9.4 in changelog * Add `ButtonStyle` enum to represent button styles in the Telegram API * Fix review issues from PR #1761 - Remove stray '-' artifact from GameHighScore docstring and butcher schema - Fix Makefile reformat target scope inconsistency (ruff check --fix) - Fix ButtonStyle enum source URL (#chat -> #inlinekeyboardbutton) - Add User.get_profile_audios() shortcut method (parallel to get_profile_photos) - Test ChatOwnerLeft with new_owner=None (edge case) - Add VideoQuality type and Video.qualities nesting tests - Add User.get_profile_audios() test Co-Authored-By: Claude Opus 4.6 <[email protected]> * Revert "Fix review issues from PR #1761" This reverts commit 2184e98. * Update source links for `ButtonStyle` documentation to reflect accurate API references * Fix review issues from PR #1761 (#1762) * Fix review issues from PR #1761 - Remove stray '-' artifact from GameHighScore docstring - Fix Makefile reformat target scope inconsistency (ruff check --fix) - Add User.get_profile_audios() shortcut method (parallel to get_profile_photos) - Test ChatOwnerLeft with new_owner=None (edge case) - Add VideoQuality type and Video.qualities nesting tests - Add User.get_profile_audios() test Co-Authored-By: Claude Opus 4.6 <[email protected]> * Address review comments: use fixture and variables in tests, add changelog Co-Authored-By: Claude Opus 4.6 <[email protected]> * Address review follow-ups for PR #1762 --------- Co-authored-by: Claude Opus 4.6 <[email protected]> * Reformat code * Shut up, ruff --------- Co-authored-by: latand <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: Kostiantyn Kriuchkov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reformattarget scope inconsistency (ruff check --fixwas using$(package_dir)instead of$(code_dir))User.get_profile_audios()shortcut method (parallel to existingget_profile_photos())ChatOwnerLeftwithnew_owner=None(edge case where owner left without designating successor)VideoQualitytype instantiation andVideo.qualitiesnesting testsUser.get_profile_audios()shortcut testNote
The
ButtonStyleenum source URL in.butcher/enums/ButtonStyle.ymlpoints to#chatinstead of#inlinekeyboardbutton— see #1761 (comment)Test plan
ChatOwnerLeftedge case)get_profile_audiostest)🤖 Generated with Claude Code