Fix getting callback params on py3.14+#1741
Merged
JrooTJunior merged 3 commits intoaiogram:dev-3.xfrom Jan 1, 2026
Merged
Conversation
✔️ Changelog found.Thank you for adding a description of the changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1741 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 591 591
Lines 13985 13999 +14
=========================================
+ Hits 13985 13999 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
andrew000
force-pushed
the
fix-callback-get-spec
branch
from
b32ade9 to
1e4a650
Compare
Add 1741.bugfix.rst
andrew000
force-pushed
the
fix-callback-get-spec
branch
from
0ec5546 to
37a5eee
Compare
JrooTJunior
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
inspect.getfullargspec(callback)can't process callback if it's arguments have "ForwardRef" annotations in Py3.14+This PR replaces the old way with
inspect.signature(callback)and addannotation_format = annotationlib.Format.FORWARDREFargument to it if runtime python version >=3.14.