Conversation
✔️ Changelog found.Thank you for adding a description of the changes |
JrooTJunior
requested changes
Apr 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #1677 by replacing the conditional type checking implementations with runtime definitions of as_markup in both InlineKeyboardMarkup and ReplyKeyboardMarkup cases.
- Removed TYPE_CHECKING blocks around as_markup methods.
- Now as_markup methods explicitly cast the result of super().as_markup, ensuring runtime functionality.
Files not reviewed (1)
- CHANGES/1677.misc.rst: Language not supported
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1678 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 568 568
Lines 13337 13341 +4
=========================================
+ Hits 13337 13341 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bug #1677 by ensuring the as_markup methods in both InlineKeyboardBuilder and ReplyKeyboardBuilder properly forward calls to their parent implementations.
- Removed TYPE_CHECKING blocks that previously provided only stub implementations
- Added runtime implementations for as_markup with appropriate docstrings
Files not reviewed (1)
- CHANGES/1677.misc.rst: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1677
Type of change
Checklist: