Skip to content

fix empty response into webhook#1665

Merged
JrooTJunior merged 1 commit intoaiogram:dev-3.xfrom
mahenzon:bugfix/fix-response-into-webhook
Apr 5, 2025
Merged

fix empty response into webhook#1665
JrooTJunior merged 1 commit intoaiogram:dev-3.xfrom
mahenzon:bugfix/fix-response-into-webhook

Conversation

@mahenzon
Copy link
Contributor

@mahenzon mahenzon commented Apr 3, 2025

Description

Fixes #1664

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally with ngrok

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Apr 3, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Apr 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (02683b8) to head (7affcce).
Report is 1 commits behind head on dev-3.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1665   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          511       511           
  Lines        12536     12536           
=========================================
  Hits         12536     12536           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aiogram/webhook/aiohttp_server.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JrooTJunior JrooTJunior requested a review from Copilot April 5, 2025 17:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • CHANGES/1664.bugfix.rst: Language not supported
Comments suppressed due to low confidence (1)

aiogram/webhook/aiohttp_server.py:159

  • The return type of _build_response_writer has been changed from MultipartWriter to Payload. Please ensure that the documentation and all consumers of this function are updated accordingly to prevent any breaking changes.
return JsonPayload({})

@JrooTJunior JrooTJunior merged commit 870d97c into aiogram:dev-3.x Apr 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Issue or PR for stable 3.x version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhook empty formdata response has unexpected format for TG

3 participants