fix: change the Downloadable protocol to be non-writable to shut up type checking that checks code that uses the bot.download(...) method#1628
Merged
JrooTJunior merged 4 commits intoaiogram:dev-3.xfrom Jan 19, 2025
monosans:patch-1
Merged
fix: change the Downloadable protocol to be non-writable to shut up type checking that checks code that uses the bot.download(...) method#1628JrooTJunior merged 4 commits intoaiogram:dev-3.xfrom monosans:patch-1
Downloadable protocol to be non-writable to shut up type checking that checks code that uses the bot.download(...) method#1628JrooTJunior merged 4 commits intoaiogram:dev-3.xfrom
monosans:patch-1
Conversation
✔️ Changelog found.Thank you for adding a description of the changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1628 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 484 484
Lines 12205 12206 +1
=========================================
+ Hits 12205 12206 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Olegt0rr
approved these changes
Jan 12, 2025
JrooTJunior
requested changes
Jan 16, 2025
Co-authored-by: Alex Root Junior <[email protected]>
monosans
changed the title
Downloadable.file_id to be writableDownloadable protocol to be non-writable to shut up type checking that checks code that uses the bot.download(...) method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code gives error with type-checkers, because
TelegramObjectis frozen andDownloadableProtocol expectsfile_idto be writable:Type of change