Fix handling of default empty string ("") in CallbackData filter#1493
Merged
JrooTJunior merged 15 commits intoaiogram:dev-3.xfrom Mar 10, 2025
Merged
Fix handling of default empty string ("") in CallbackData filter#1493JrooTJunior merged 15 commits intoaiogram:dev-3.xfrom
JrooTJunior merged 15 commits intoaiogram:dev-3.xfrom
Conversation
Allows using a default value in the class which is equal to an empty string ("").
Example:
class MyCallbackData(CallbackData, prefix="MyCallbackData"):
input1: str
input2: str = ""
✔️ Changelog found.Thank you for adding a description of the changes |
Fixed an issue that prevented unpacking None values.
Member
|
Please merge branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1493 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 485 485
Lines 12251 12252 +1
=========================================
+ Hits 12251 12252 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JrooTJunior
approved these changes
May 30, 2024
JrooTJunior
requested changes
May 30, 2024
Member
JrooTJunior
left a comment
There was a problem hiding this comment.
Please add tests that cover your changes
Olegt0rr
suggested changes
Jun 12, 2024
Olegt0rr
suggested changes
Jun 12, 2024
Contributor
Author
|
Hello @JrooTJunior, @Olegt0rr, I've updated the PR with the requested changes. Please review it and let me know if any further adjustments are needed. Thank you! |
JrooTJunior
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling of default empty string ("") in CallbackData filter.
Description
Previously, the filter did not activate if a field in the CallbackData class had a default value set to an empty string (""). This update fixes that behavior, ensuring the filter functions correctly in such cases.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: