Allow replacing path without replacing query or fragment#1421
Merged
asvetlov merged 25 commits intoaio-libs:masterfrom Nov 21, 2024
Merged
Allow replacing path without replacing query or fragment#1421asvetlov merged 25 commits intoaio-libs:masterfrom
asvetlov merged 25 commits intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
CodSpeed Performance ReportMerging #1421 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
+ Coverage 96.04% 96.11% +0.06%
==========================================
Files 31 31
Lines 5770 5871 +101
Branches 348 348
==========================================
+ Hits 5542 5643 +101
Misses 202 202
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asvetlov
reviewed
Nov 18, 2024
bdraco
reviewed
Nov 18, 2024
bdraco
reviewed
Nov 18, 2024
bdraco
reviewed
Nov 18, 2024
bdraco
reviewed
Nov 18, 2024
bdraco
reviewed
Nov 18, 2024
bdraco
reviewed
Nov 18, 2024
bdraco
changed the title
bdraco
reviewed
Nov 18, 2024
bdraco
previously approved these changes
Nov 18, 2024
Member
|
reframed this as a new feature since the current behavior doesn't change and its by design. All the functionality here is new. |
Member
|
bdraco
dismissed
their stale review
We also need to update the docs for with_path
Member
|
One last thing, we also need to update the docs for |
Member
|
We also have |
Co-authored-by: Andrew Svetlov <[email protected]>
bdraco
reviewed
Nov 19, 2024
bdraco
approved these changes
Nov 19, 2024
Member
|
We will also need to bump the version to 1.18.0.dev0 after merging this PR |
Member
Technically, we can do it right now. |
Merged
webknjaz
reviewed
Nov 19, 2024
webknjaz
reviewed
Nov 19, 2024
webknjaz
reviewed
Nov 19, 2024
asvetlov
reviewed
Nov 19, 2024
asvetlov
reviewed
Nov 19, 2024
asvetlov
requested changes
Nov 19, 2024
Member
asvetlov
left a comment
asvetlov
left a comment
There was a problem hiding this comment.
Please update affected method signatures in docs to reflect added parameters.
webknjaz
approved these changes
Nov 20, 2024
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
bdraco
approved these changes
Nov 20, 2024
asvetlov
reviewed
Nov 20, 2024
Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add keep_query and keep_fragment arguments to with_path function to allow replacing path without replacing query or fragment
Are there changes in behavior for the user?
Yes, users can now replace the path in a URL without unintentionally modifying the query string or fragment by using the new arguments. Existing behavior remains unchanged unless the new arguments are explicitly used.
Related issue number
closes #111
Checklist