Fixed type annotations for keys of multidict mapping classes#677
Merged
asvetlov merged 4 commits intoaio-libs:masterfrom Jan 22, 2022
Merged
Fixed type annotations for keys of multidict mapping classes#677asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov merged 4 commits intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Member
|
Could you fill out the PR title/description? |
webknjaz
reviewed
Jan 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 5 5
Lines 498 498
=======================================
Hits 467 467
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
asvetlov
changed the title
asvetlov
approved these changes
Jan 22, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref:
python/mypy#8477
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Fixes #644
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.