Skip to content

Reformat#1116

Closed
asvetlov wants to merge 3 commits intomasterfrom
reformat
Closed

Reformat#1116
asvetlov wants to merge 3 commits intomasterfrom
reformat

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Apr 1, 2025

No description provided.

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Apr 1, 2025
@asvetlov asvetlov marked this pull request as ready for review April 1, 2025 13:21
Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a contrib change note, then. And a blame ignore update in a follow-up.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (e442d73) to head (badc188).
Report is 95 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1116   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files          42       42           
  Lines        6176     6176           
  Branches      618      618           
=======================================
  Hits         5637     5637           
  Misses        105      105           
  Partials      434      434           
Flag Coverage Δ
CI-GHA 91.27% <0.00%> (ø)
MyPy 83.58% <0.00%> (ø)
pytest 100.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #1116 will not alter performance

Comparing reformat (badc188) with master (e442d73)

Summary

✅ 244 untouched benchmarks

@webknjaz webknjaz removed the bot:chronographer:skip This PR does not need to include a change note label Apr 1, 2025
@asvetlov
Copy link
Copy Markdown
Member Author

asvetlov commented Apr 1, 2025

  1. Reformatting should not go to changelog, IMHO.
  2. We squash commits. It means that the blame ignore could be added by the next PR only (I prefer don't do it, honestly. The diff is very tiny).

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Apr 1, 2025

This PR doesn't only contain formatting but a contributor-facing configuration change. And yes, blame ignore should be in a follow up.

@asvetlov
Copy link
Copy Markdown
Member Author

asvetlov commented Apr 1, 2025

Are you talking about black --py39 ... option?
Ok, I've reverted it back -- it doesn't change anything for the project.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Apr 1, 2025

might be nice to format the C code with something like https://github.com/ratgdo/esphome-ratgdo/blob/05967a5cb1e27341e55917188c79ca80a610da5f/.pre-commit-config.yaml#L10 as well (no preferences on the settings, other than to not have to think about it)

@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants