Repository navigation
Commit d220522
authored
Upload release assets one at a time to avoid the secondary rate limit (#1503)
<!-- Thank you for your contribution! -->
## What do these changes do?
The v6.9.0 deploy job
([run](https://github.com/aio-libs/multidict/actions/runs/35338595754/job/105598615903))
failed on the last step: `softprops/action-gh-release` uploaded 513
files to the GitHub Release in parallel and GitHub rejected the burst
with a secondary rate limit error after 499 of them. PyPI publishing and
Sigstore signing had already succeeded.
The step is replaced with a shell loop that uploads one file at a time
with `gh release upload`, skips assets already attached to the release,
and retries each upload up to five times with an increasing pause. A
re-run of the job therefore only fills in what a previous attempt
missed. The set of files attached to the release is unchanged.
The 14 wheels missing from v6.9.0 were uploaded by hand from the run
artifacts after checking their SHA256 against the Sigstore bundles on
the release and against PyPI; the release now has all 513 assets.
## Are there changes in behavior for the user?
No.
## Is it a substantial burden for the maintainers to support this?
No, it is a short shell step with no third party action.
## Related issue number
N/A
## Checklist
- [x] I think the code is well written
- [ ] Unit tests for the changes exist N/A, release workflow only
- [ ] Documentation reflects the changes N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`
<details>
<summary>Agent run details (optional, for reviewers)</summary>
Lint: `pre-commit run --files .github/workflows/ci-cd.yml` passed
(actionlint, timeout-minutes check, yamllint).
Spelling: `make doc-spelling` passed.
Dry run: the skip logic was run against the live v6.9.0 release with the
upload replaced by `echo`; it selected exactly the 14 missing wheels and
skipped files already attached. The real upload path only runs on a
release tag and was not exercised end to end.
</details>
Drafted with Claude Opus 5 (Claude Code); reviewed by @asvetlov.1 parent 30cd596 commit d220522
2 files changed
Lines changed: 32 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
944 | 944 | | |
945 | 945 | | |
946 | 946 | | |
947 | | - | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
948 | 950 | | |
949 | 951 | | |
950 | 952 | | |
| |||
1028 | 1030 | | |
1029 | 1031 | | |
1030 | 1032 | | |
1031 | | - | |
1032 | | - | |
1033 | | - | |
1034 | | - | |
1035 | | - | |
1036 | | - | |
1037 | | - | |
1038 | | - | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
1039 | 1057 | | |
1040 | 1058 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
0 commit comments