Repository navigation
Commit 3c3fc84
authored
Move istr_canonical() into istr_object.h (#1754)
<!-- Thank you for your contribution! -->
## What do these changes do?
Moves `istr_canonical()` from `htkeys.h` to `istr_object.h`, next to the
`istrobject` struct it reads, and uses it in `identity.h` in place of
the three direct `((istrobject*)key)->canonical` reads. The only
remaining direct accesses are in `istr.h`, where the field is set and
released. C extension only; the pure-Python backend has no equivalent.
## Are there changes in behavior for the user?
No.
## Is it a substantial burden for the maintainers to support this?
No, it is a header reshuffle with no code generation change expected.
## Related issue number
N/A
## Checklist
- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, no behaviour change;
covered by the existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`
Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.
<details>
<summary>Agent run details (optional, for reviewers)</summary>
Tests, C extension: `pytest -q` on 3.14.7 (4198 passed, 182 skipped) and
3.10.17 (4202 passed, 178 skipped)
Tests, pure Python: `MULTIDICT_NO_EXTENSIONS=1 pytest -q
--no-c-extensions` on 3.14.7 (1664 passed, 24 skipped)
Inlining: `tools/check_inlining.py` on 3.14.7 and 3.14.7t, ok (12 and 16
rules)
Docs: `make doc-spelling`, build succeeded
</details>1 parent ccdd836 commit 3c3fc84
4 files changed
Lines changed: 11 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | 215 | | |
222 | 216 | | |
223 | 217 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
| 244 | + | |
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| |||
260 | 260 | | |
261 | 261 | | |
262 | 262 | | |
263 | | - | |
| 263 | + | |
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
20 | 26 | | |
21 | 27 | | |
22 | 28 | | |
| |||
0 commit comments