-
-
Notifications
You must be signed in to change notification settings - Fork 102
Stop inheriting from StreamReaderProtocol? #210
Copy link
Copy link
Open
Labels
compatibilityin progressSomeone has started working on the issue but no PR yetSomeone has started working on the issue but no PR yettech-debtThings that needs to be tidied up to avoid being bitten in the future...Things that needs to be tidied up to avoid being bitten in the future...
Milestone
Metadata
Metadata
Assignees
Labels
compatibilityin progressSomeone has started working on the issue but no PR yetSomeone has started working on the issue but no PR yettech-debtThings that needs to be tidied up to avoid being bitten in the future...Things that needs to be tidied up to avoid being bitten in the future...
I was in the process of eyeballing the docs and fixing things when I came upon a
:ref:that steadfastly refused to resolve:After hunting around, apparently that class was last documented in Python 3.6: https://docs.python.org/3.6/library/asyncio-stream.html#streamreaderprotocol
It's gone since Python 3.7, that's why the
:ref:won't resolve.Digging deeper, I found
bpo-37639with comment from @asvetlov (I'm assuming the same person, apologies if not):So, will we stop inheriting from that class and as suggested, just copy-and-paste the source lines?
I fear that one day things will blow up if this class's definition got removed and/or remade... which is why I'm adding the
[tech-debt]label there.