Skip to content

Test failures and DeprecationWarnings in Python 3.8 #167

@tirkarthi

Description

@tirkarthi

There are test case failures in Python 3.8 . I think this is due to mocking create_server which is now AsyncMock instead of MagicMock with changes in https://bugs.python.org/issue26467 where coroutines when patched return AsyncMock. Thus there are warnings due to the mock not being awaited. The old behavior can be used with MagicMock explicitly passed while patching. There also seems to be a bug that AsyncMock is not recording call_args and other values for synchronous API.

There is also DeprecationWarning since StreamReader and StreamWriter are merged into Stream class in https://bugs.python.org/issue36889. Attached is a log with 3.9.0a0 but these are reproducible on 3.8.0b1 as well.

aiosmptd.log

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions