Rename RequestHeader_vX classes#1141
Merged
ods merged 1 commit intoaio-libs:masterfrom Dec 12, 2025
Merged
Conversation
According the java client schema, v0 was a version only used for ControlledShutdownRequest. The first version to have a client id was version 1. https://github.com/apache/kafka/blob/2.8.1/clients/src/main/resources/common/message/RequestHeader.json There could have been a confusion as in KIP-482, the v2 is named "version 1". https://cwiki.apache.org/confluence/display/KAFKA/KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged+Fields
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 88 88
Lines 15710 15710
Branches 1374 1374
=======================================
Hits 14896 14896
Misses 569 569
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According the java client schema, v0 was a version only used for ControlledShutdownRequest.
The first version to have a client id was version 1.
https://github.com/apache/kafka/blob/2.8.1/clients/src/main/resources/common/message/RequestHeader.json
There could have been a confusion as in KIP-482, the v2 is named "version 1".
https://cwiki.apache.org/confluence/display/KAFKA/KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged+Fields
Changes
Fixes #
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.