1115.bugfix: Make KafkaStorageError retriable after metadata refresh#1115
Conversation
This is how it is in the java implementation and in kafka-python [Java Implementation](https://kafka.apache.org/30/javadoc/org/apache/kafka/common/errors/KafkaStorageException.html) ``` Client should request metadata update and retry if the response shows KafkaStorageException ``` [kafka-python](https://github.com/dpkp/kafka-python/blob/20e2d52ff2c337e02f8bac7af6c6e8d00ebcc63f/kafka/errors.py#L546) ```Python class KafkaStorageError(BrokerResponseError): errno = 56 message = 'KAFKA_STORAGE_ERROR' description = 'Disk error when trying to access log file on the disk.' retriable = True invalid_metadata = True ```
omerhadari
changed the title
omerhadari
force-pushed
the
fix/align-kafka-storage-error-with-other-implementations
branch
from
31f7350 to
0e72db2
Compare
|
Hi @ods, any chance this could get reviewed and a version released? Sorry for tagging you directly. We are getting errors in production which we have to bypass in ways that don't respect other client configs (e.g. request_timeout_ms). Thank you! |
|
Hi @omerhadari! Thanks for the contribution, looks good to me. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
- Coverage 95.08% 85.95% -9.14%
==========================================
Files 114 114
Lines 16981 16983 +2
Branches 1579 1579
==========================================
- Hits 16146 14597 -1549
- Misses 486 1994 +1508
- Partials 349 392 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you so much! Will there be a release soon? |
2 participants
This error is supposed to be automatically retried by clients, but currently it is not.
This is how it is in the java implementation and in kafka-python
Java Implementation
kafka-python