Fix incomplete documentation for AIOKafkaConsumer.offset_for_times#1068
Merged
ods merged 1 commit intoaio-libs:masterfrom Oct 31, 2024
Merged
Fix incomplete documentation for AIOKafkaConsumer.offset_for_times#1068ods merged 1 commit intoaio-libs:masterfrom
ods merged 1 commit intoaio-libs:masterfrom
Conversation
Updates the return description to be in line with the behaviour of the offset_for_times function and the official Kafka documentation.
Collaborator
|
Hi @jzvandenoever, thank you for the contribution! You're right, and we even have a test for such case. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 114 114
Lines 16980 16980
Branches 1579 1579
=======================================
Hits 16150 16150
Misses 482 482
Partials 348 348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1067
Updates the return description to be in line with the behaviour of the
offset_for_times function and the official Kafka documentation.