CodSpeed Performance Report

Merging #9732 will not alter performance

_{Comparing client_middleware (ab1aac2) with master (e5d1240)}

Summary

✅ 60 untouched benchmarks

Also #6915. There are some examples in there of different use cases which should work when this is complete.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (e5d1240) to head (ab1aac2).
⚠️ Report is 516 commits behind head on master.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##           master    #9732      +/-   ##
==========================================
+ Coverage   98.71%   98.74%   +0.02%     
==========================================
  Files         125      127       +2     
  Lines       37894    38520     +626     
  Branches     2094     2123      +29     
==========================================
+ Hits        37407    38036     +629     
+ Misses        338      336       -2     
+ Partials      149      148       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since we're generally happy with the design now (as discussed on Matrix), I'll go ahead and merge this to unblock the follow-up work. Any further adjustments can be handled in a separate PR.

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 1e911ea on top of patchback/backports/3.12/1e911eaf23091b42cc374547ff9bf692debf9720/pr-9732

Backporting merged PR #9732 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.12/1e911eaf23091b42cc374547ff9bf692debf9720/pr-9732 upstream/3.12

4. Now, cherry-pick PR Add Client Middleware Support #9732 contents into that branch:

   $ git cherry-pick -x 1e911eaf23091b42cc374547ff9bf692debf9720

   If it'll yell at you with something like fatal: Commit 1e911eaf23091b42cc374547ff9bf692debf9720 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x 1e911eaf23091b42cc374547ff9bf692debf9720

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Add Client Middleware Support #9732 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.12/1e911eaf23091b42cc374547ff9bf692debf9720/pr-9732

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Didn't think I would be that lucky that it wouldn't conflict 😄

Thanks for the review. I'll clean this up between sprint work.