Skip to content

[PR #9600/e6187f6 backport][3.10] Avoid starting connection timeout when a connection is already available#9673

Merged
bdraco merged 1 commit into3.10from
patchback/backports/3.10/e6187f6808d647243d8cee115ec24c3eb1421183/pr-9600
Nov 5, 2024
Merged

[PR #9600/e6187f6 backport][3.10] Avoid starting connection timeout when a connection is already available#9673
bdraco merged 1 commit into3.10from
patchback/backports/3.10/e6187f6808d647243d8cee115ec24c3eb1421183/pr-9600

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Nov 5, 2024

This was originally planned not to backport to 3.10, but its needed to fixup #9670

(cherry picked from commit e6187f6)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 5, 2024
@bdraco bdraco changed the title Avoid starting connection timeout when a connection is already available (#9600) [PR #9600/e6187f6 backport][3.10] Avoid starting connection timeout when a connection is already available Nov 5, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #9673 will not alter performance

Comparing patchback/backports/3.10/e6187f6808d647243d8cee115ec24c3eb1421183/pr-9600 (5ca920e) with 3.10 (a103e61)

Summary

✅ 13 untouched benchmarks

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (a103e61) to head (5ca920e).
Report is 60 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #9673      +/-   ##
==========================================
+ Coverage   97.85%   97.86%   +0.01%     
==========================================
  Files         112      112              
  Lines       35322    35329       +7     
  Branches     4246     4248       +2     
==========================================
+ Hits        34563    34574      +11     
+ Misses        566      562       -4     
  Partials      193      193              
Flag Coverage Δ
CI-GHA 97.75% <100.00%> (+0.01%) ⬆️
OS-Linux 97.43% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.99% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.13% <100.00%> (+0.01%) ⬆️
Py-3.10.11 96.99% <97.43%> (+<0.01%) ⬆️
Py-3.10.15 96.93% <97.43%> (+<0.01%) ⬆️
Py-3.11.10 97.01% <97.43%> (+<0.01%) ⬆️
Py-3.11.9 97.08% <97.43%> (+0.01%) ⬆️
Py-3.12.7 97.47% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.45% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.38% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.90% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.85% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.45% <100.00%> (+<0.01%) ⬆️
VM-macos 97.13% <100.00%> (+0.01%) ⬆️
VM-ubuntu 97.43% <100.00%> (+<0.01%) ⬆️
VM-windows 94.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review November 5, 2024 15:11
@bdraco bdraco merged commit e141032 into 3.10 Nov 5, 2024
@bdraco bdraco deleted the patchback/backports/3.10/e6187f6808d647243d8cee115ec24c3eb1421183/pr-9600 branch November 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant