Skip to content

[PR #9207/970c5d9 backport][3.11] add proxy and proxy_auth variables to ClientSession.__init__#9331

Merged
bdraco merged 7 commits intoaio-libs:3.11from
meshya:patchback/backports/3.11/970c5d9d84afc8fb762ff04940b5e25449a1f6ae/pr-9207
Oct 1, 2024
Merged

[PR #9207/970c5d9 backport][3.11] add proxy and proxy_auth variables to ClientSession.__init__#9331
bdraco merged 7 commits intoaio-libs:3.11from
meshya:patchback/backports/3.11/970c5d9d84afc8fb762ff04940b5e25449a1f6ae/pr-9207

Conversation

@meshya
Copy link
Copy Markdown
Contributor

@meshya meshya commented Sep 28, 2024

(cherry picked from commit 970c5d9)

What do these changes do?

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 28, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (ac48753) to head (f289444).
Report is 341 commits behind head on 3.11.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9331   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         108      108           
  Lines       35070    35099   +29     
  Branches     4187     4191    +4     
=======================================
+ Hits        34299    34328   +29     
  Misses        574      574           
  Partials      197      197           
Flag Coverage Δ
CI-GHA 97.68% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.36% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.87% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.92% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 96.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.00% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 97.40% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 97.38% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.84% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.78% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.38% <100.00%> (+<0.01%) ⬆️
VM-macos 97.06% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.36% <100.00%> (+<0.01%) ⬆️
VM-windows 94.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer changed the base branch from master to 3.11 September 29, 2024 12:04
@bdraco bdraco changed the title add proxy and proxy_auth varriables to ClientSession.__init__ (#9207) [PR #9207/970c5d9 backport][3.11] add proxy and proxy_auth variables to ClientSession.__init__ Oct 1, 2024
@bdraco bdraco enabled auto-merge (squash) October 1, 2024 19:40
@bdraco bdraco merged commit e238777 into aio-libs:3.11 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants