Skip to content

Fix empty ALLOW Response header for cls based View#929

Merged
asvetlov merged 1 commit intoaio-libs:0.21from
singulared:0.21
Jul 7, 2016
Merged

Fix empty ALLOW Response header for cls based View#929
asvetlov merged 1 commit intoaio-libs:0.21from
singulared:0.21

Conversation

@singulared
Copy link
Copy Markdown
Contributor

@singulared singulared commented Jun 16, 2016 •
edited
Loading

What do these changes do?

Fix empty ALLOW Response header for cls based View

We must check existing lower http method names for assembling
ALLOW header and passing into web.HTTPMethodNotAllowed.

Are there changes in behavior for the user?

yes

Related issue number

No issue

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@singulared
Fix empty ALLOW Response header for cls based View
60314da 
We must check existing lower http method names for assembing
ALLOW header and passing into web.HTTPMethodNotAllowed.
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Jul 6, 2016

Very sorry for late answer but you are asking for ability to write def get() instead of def GET() as I understand.
Why?

@singulared
Copy link
Copy Markdown
Contributor Author

singulared commented Jul 6, 2016

Hi! i think lowercase is more pythonic. In other case i did't have valid ALLOW response header if i use def get(). But i can use it as request handler.

@singulared
Copy link
Copy Markdown
Contributor Author

singulared commented Jul 7, 2016

Docs use lowercase methods:
http://aiohttp.readthedocs.io/en/stable/web_reference.html#view

@asvetlov asvetlov merged commit f90f988 into aio-libs:0.21 Jul 7, 2016
@asvetlov
Copy link
Copy Markdown
Member

asvetlov commented Jul 7, 2016

Ok.
Thanks!

@lock
Copy link
Copy Markdown

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@singulared @asvetlov