Merged
Conversation
Make the function that checks whether a string is an ip address or not easier to access on it's own, so that it can be tested more easily. Fix accompanying test.
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What these changes does?
This is to finish the work done in PR #874 for the PyCon sprints. I have added using a regex to check if a host is an IP address, which is ~2x more efficient according to
timeit.How to test your changes?
I have added tests for the regex, let me know if these should be more extensive. It is more important to make sure that we do not qualify something that needs a DNS lookup as an IP, than the other way around. I was not concerned about host strings that were neither a valid IP or a domain, as this is an error either way.
Checklist