Use a create_future compatibility wrapper instead of creating Futures directly#896
Merged
asvetlov merged 3 commits intoaio-libs:masterfrom Jun 2, 2016
Merged
Conversation
Apply the asyncio.Future() -> helpers.create_future() refactoring to the tests as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What these changes does?
Adds the
create_futurecompat wrapper (and tests) discussed at the PyCon 2016 sprint.How to test your changes?
The
make testsuite includes mock tests to ensure the wrapper is functioning.Related issue number
Issue #893
Checklist