[PR #5344/bff76313 backport][3.10] Fix StreamResponse.prepared not returning True after EOF is sent#8893
Merged
Dreamsorcerer merged 1 commit into3.10from Aug 26, 2024
Conversation
(cherry picked from commit bff7631)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.10 #8893 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 108 108
Lines 34205 34209 +4
Branches 4068 4068
=======================================
+ Hits 33420 33424 +4
Misses 586 586
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Dreamsorcerer
deleted the
patchback/backports/3.10/bff76313298d8b2c7539f9dc496801ee86ab7097/pr-5344
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5344 as merged into master (bff7631).
Fixes #5343
I renamed a few tests (i think the
preparedattribute used to be namedstartedand the tests were not renamed?)And I removed some asserts around prepare in a
test___repr__test - to move them to a dedicated test