Fix monkey patches for pathlib changes in Python 3.13#8619
Fix monkey patches for pathlib changes in Python 3.13#8619bdraco merged 1 commit intoaio-libs:masterfrom
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8619 +/- ##
==========================================
- Coverage 97.70% 97.70% -0.01%
==========================================
Files 107 107
Lines 33438 33439 +1
Branches 3927 3928 +1
==========================================
Hits 32672 32672
Misses 555 555
- Partials 211 212 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
changed the title
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8623 🤖 @patchback |
(cherry picked from commit d1c8dfb)
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #8624 🤖 @patchback |
(cherry picked from commit d1c8dfb)
…nges in Python 3.13 (#8624) Co-authored-by: Steve Repsher <[email protected]>
…nges in Python 3.13 (#8623) Co-authored-by: Steve Repsher <[email protected]>
2 participants
What do these changes do?
Just alters a couple of mocks to accept
**kwargs. This makes them compatible withfollow_symlinksadded tois_file()andis_dir()in 3.13.Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
No
Related issue number
Fixes #8551
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.