'request.logger' > 'request.app.logger' in StaticFileMixin#856
Merged
asvetlov merged 1 commit intoaio-libs:0.21from Jun 2, 2016
samuelcolvin:static-file-error-fix
Merged
'request.logger' > 'request.app.logger' in StaticFileMixin#856asvetlov merged 1 commit intoaio-libs:0.21from samuelcolvin:static-file-error-fix
asvetlov merged 1 commit intoaio-libs:0.21from
samuelcolvin:static-file-error-fix
Conversation
Member
Author
|
@asvetlov any chance of merging this? I see it's still broken in master too. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I believe this error exists on master too, but i'm using 0.21 as base as per the instructions).
What these changes does?
prevent 500 exception with extremely long url requests to the static file router.
This is a slightly ugly way of getting the error to occur, presumably there are other causes of a suitable exception, but this how I found the error and seems to demonstrate the point.
The code causing the error was not previously covered.
How to test your changes?
see test below
Checklist