Skip to content

Small cleanup to wss/ws fix#8513

Merged
bdraco merged 9 commits intomasterfrom
wss_cleanup
Jul 20, 2024
Merged

Small cleanup to wss/ws fix#8513
bdraco merged 9 commits intomasterfrom
wss_cleanup

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Jul 17, 2024

followup to #8482

What do these changes do?

post merge review comments #8482 (comment) #8482 (comment)

Are there changes in behavior for the user?

n/a

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco requested review from asvetlov and webknjaz as code owners July 17, 2024 19:29
@bdraco bdraco mentioned this pull request Jul 17, 2024
Merged
5 tasks
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 labels Jul 17, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 17, 2024
View reviewed changes
tests/test_client_session.py
for c in connections:
c.close()
del c
c.__del__()

Check warning

Code scanning / CodeQL

`__del__` is called explicitly

The __del__ special method is called explicitly.
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (43b10dc) to head (e695ba6).
Report is 917 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8513   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files         107      107           
  Lines       33262    33262           
  Branches     3905     3905           
=======================================
  Hits        32472    32472           
  Misses        571      571           
  Partials      219      219
Flag Coverage Δ
CI-GHA 97.54% <100.00%> (ø)
OS-Linux 97.20% <100.00%> (ø)
OS-Windows 95.66% <100.00%> (ø)
OS-macOS 96.87% <100.00%> (ø)
Py-3.10.11 97.01% <100.00%> (ø)
Py-3.10.14 96.96% <100.00%> (ø)
Py-3.11.9 97.18% <100.00%> (ø)
Py-3.12.4 97.31% <100.00%> (ø)
Py-3.8.10 95.43% <100.00%> (ø)
Py-3.8.18 96.85% <100.00%> (ø)
Py-3.9.13 97.00% <100.00%> (ø)
Py-3.9.19 96.96% <100.00%> (ø)
Py-pypy7.3.16 96.53% <100.00%> (ø)
VM-macos 96.87% <100.00%> (ø)
VM-ubuntu 97.20% <100.00%> (ø)
VM-windows 95.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

webknjaz
webknjaz reviewed Jul 17, 2024
View reviewed changes
webknjaz
webknjaz reviewed Jul 17, 2024
View reviewed changes
webknjaz
webknjaz reviewed Jul 17, 2024
View reviewed changes
@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 18, 2024

@bdraco so I linked both the PR and the issue and this is how it renders: https://aiohttp--8513.org.readthedocs.build/en/8513/changes.html#features.

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 18, 2024

I also updated the original note byline with proper credits

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 19, 2024

Thanks @webknjaz

My day job is eating up all my time right now. I should have a chance to followup this weekend

@webknjaz webknjaz closed this Jul 19, 2024
@webknjaz webknjaz reopened this Jul 19, 2024
bdraco
bdraco commented Jul 20, 2024
View reviewed changes
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jul 20, 2024

Thanks @webknjaz

I see what your intent was now. Much appreciated.

@bdraco bdraco enabled auto-merge (squash) July 20, 2024 12:58
@bdraco bdraco merged commit bbe90e5 into master Jul 20, 2024
@bdraco bdraco deleted the wss_cleanup branch July 20, 2024 13:12
@patchback
Copy link
Copy Markdown
Contributor

patchback bot commented Jul 20, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/bbe90e5d9bbb456221ae85024588a87be835d7a3/pr-8513

Backported as #8519

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 20, 2024
@bdraco @webknjaz @patchback
Small cleanup to wss/ws fix (#8513)
c52ea4a 
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit bbe90e5)
@patchback patchback bot mentioned this pull request Jul 20, 2024
Merged
@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Jul 20, 2024

No problem! Sorry I was unable to relay it more clearly.. One day, I'll document it properly.

bdraco added a commit that referenced this pull request Jul 20, 2024
@patchback @bdraco
[PR #8513/bbe90e5d backport][3.10] Small cleanup to wss/ws fix (#8519)
fe43939 
Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

+1 more reviewer

@AraHaan AraHaan AraHaan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bdraco @webknjaz @AraHaan @github-advanced-security